Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2100703003: Convert video-seek* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-seek* tests to testharness.js Cleaning up video-seek* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/278bd74563e00bf0abbae6594c34b1680a7ed428 Cr-Commit-Position: refs/heads/master@{#402169}

Patch Set 1 #

Total comments: 8

Patch Set 2 : address comments #

Messages

Total messages: 12 (6 generated)
Srirama
PTAL
4 years, 5 months ago (2016-06-27 11:57:47 UTC) #3
fs
lgtm https://codereview.chromium.org/2100703003/diff/1/third_party/WebKit/LayoutTests/media/video-seek-past-end-playing.html File third_party/WebKit/LayoutTests/media/video-seek-past-end-playing.html (right): https://codereview.chromium.org/2100703003/diff/1/third_party/WebKit/LayoutTests/media/video-seek-past-end-playing.html#newcode13 third_party/WebKit/LayoutTests/media/video-seek-past-end-playing.html:13: video.oncanplaythrough = null; Nit: indentation https://codereview.chromium.org/2100703003/diff/1/third_party/WebKit/LayoutTests/media/video-seek-to-duration-with-playbackrate-zero.html File third_party/WebKit/LayoutTests/media/video-seek-to-duration-with-playbackrate-zero.html ...
4 years, 5 months ago (2016-06-27 12:09:54 UTC) #4
Srirama
https://codereview.chromium.org/2100703003/diff/1/third_party/WebKit/LayoutTests/media/video-seek-past-end-playing.html File third_party/WebKit/LayoutTests/media/video-seek-past-end-playing.html (right): https://codereview.chromium.org/2100703003/diff/1/third_party/WebKit/LayoutTests/media/video-seek-past-end-playing.html#newcode13 third_party/WebKit/LayoutTests/media/video-seek-past-end-playing.html:13: video.oncanplaythrough = null; On 2016/06/27 12:09:54, fs wrote: > ...
4 years, 5 months ago (2016-06-27 13:10:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100703003/20001
4 years, 5 months ago (2016-06-27 13:10:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 14:21:14 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 14:22:30 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/278bd74563e00bf0abbae6594c34b1680a7ed428
Cr-Commit-Position: refs/heads/master@{#402169}

Powered by Google App Engine
This is Rietveld 408576698