Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2100703002:
🎍 Add field counts to method_count.py (Closed)
|
Created:
4 years, 5 months ago by agrieve Modified:
4 years, 5 months ago CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, smaier Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd more metrics to method_count.py: fields, classes, strings
These might be useful to track as well.
BUG=none
Committed: https://crrev.com/876e2e652e9a1975048c96b83bd510c41a93798f
Cr-Commit-Position: refs/heads/master@{#402675}
Patch Set 1 #
Total comments: 4
Patch Set 2 : add even more stats. refactor logic. #
Total comments: 4
Patch Set 3 : defaultdict #Messages
Total messages: 21 (10 generated)
Description was changed from ========== Add field counts to method_count.py Figured it would be a good number to track as well. BUG=none ========== to ========== Add field counts to method_count.py Figured it would be a good number to track as well. BUG=none ==========
agrieve@chromium.org changed reviewers: + jbudorick@chromium.org
On 2016/06/27 00:40:52, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org
https://codereview.chromium.org/2100703002/diff/1/build/android/method_count.py File build/android/method_count.py (right): https://codereview.chromium.org/2100703002/diff/1/build/android/method_count.... build/android/method_count.py:38: def _SingleMethodAndFieldCount(dex_path): I forget what else is in the dexdump -- would we potentially want to parse more in the future, and if so, should we give these two functions more forward-compatible names? https://codereview.chromium.org/2100703002/diff/1/build/android/method_count.... build/android/method_count.py:54: return fields, methods nit: If this stays "SingleMethodAndFieldCount", it should return these two in the opposite order https://codereview.chromium.org/2100703002/diff/1/build/android/method_count.... build/android/method_count.py:67: return total_fields, total_methods nit: same https://codereview.chromium.org/2100703002/diff/1/build/android/method_count.... build/android/method_count.py:95: perf_tests_results_helper.PrintPerfResult( kinda odd to have method_count.py doing this as well, but probably not worth renaming it.
smaier@chromium.org changed reviewers: + smaier@chromium.org
lgtm - good change to be made.
On 2016/06/27 13:33:57, smaier wrote: > lgtm - good change to be made. Reworked it to just collect all sizes and print the ones we think might be useful. ptal.
Description was changed from ========== Add field counts to method_count.py Figured it would be a good number to track as well. BUG=none ========== to ========== Add more metrics to method_count.py: fields, classes, strings These might be useful to track as well. BUG=none ==========
lgtm w/ nits hah, now the module name is way off https://codereview.chromium.org/2100703002/diff/20001/build/android/method_co... File build/android/method_count.py (right): https://codereview.chromium.org/2100703002/diff/20001/build/android/method_co... build/android/method_count.py:64: counts = None nit: counts = collections.defaultdict(int) https://codereview.chromium.org/2100703002/diff/20001/build/android/method_co... build/android/method_count.py:71: if counts is None: nit: w/ the defaultdict, this if block can go away
https://codereview.chromium.org/2100703002/diff/20001/build/android/method_co... File build/android/method_count.py (right): https://codereview.chromium.org/2100703002/diff/20001/build/android/method_co... build/android/method_count.py:64: counts = None On 2016/06/28 17:35:29, jbudorick (EMEA til June 30) wrote: > nit: counts = collections.defaultdict(int) Done. https://codereview.chromium.org/2100703002/diff/20001/build/android/method_co... build/android/method_count.py:71: if counts is None: On 2016/06/28 17:35:29, jbudorick (EMEA til June 30) wrote: > nit: w/ the defaultdict, this if block can go away Done.
The CQ bit was checked by agrieve@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from smaier@chromium.org, jbudorick@chromium.org Link to the patchset: https://codereview.chromium.org/2100703002/#ps40001 (title: "defaultdict")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add more metrics to method_count.py: fields, classes, strings These might be useful to track as well. BUG=none ========== to ========== Add more metrics to method_count.py: fields, classes, strings These might be useful to track as well. BUG=none ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add more metrics to method_count.py: fields, classes, strings These might be useful to track as well. BUG=none ========== to ========== Add more metrics to method_count.py: fields, classes, strings These might be useful to track as well. BUG=none Committed: https://crrev.com/876e2e652e9a1975048c96b83bd510c41a93798f Cr-Commit-Position: refs/heads/master@{#402675} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/876e2e652e9a1975048c96b83bd510c41a93798f Cr-Commit-Position: refs/heads/master@{#402675} |
