Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2100693002: Make RenderProcessHost/RenderThread use MojoChildConnection/MojoShellConnection (Closed)

Created:
4 years, 5 months ago by Ben Goodger (Google)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@rph2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make RenderProcessHost/RenderThread use MojoChildConnection/MojoShellConnection Extracted from: https://codereview.chromium.org/2096643002/ TBR=rockot@chromium.org BUG= Committed: https://crrev.com/b4e2536de302ecbc29ad7a40fc124e15e7c74e77 Cr-Commit-Position: refs/heads/master@{#402225}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -60 lines) Patch
M content/browser/mojo/mojo_child_connection.h View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
M content/browser/mojo/mojo_child_connection.cc View 1 2 3 2 chunks +4 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 10 chunks +39 lines, -32 lines 0 comments Download
M content/child/child_thread_impl.h View 1 6 chunks +14 lines, -1 line 0 comments Download
M content/child/child_thread_impl.cc View 1 2 5 chunks +45 lines, -12 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.h View 1 2 3 chunks +5 lines, -1 line 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 1 2 2 chunks +33 lines, -1 line 0 comments Download
M content/public/child/child_thread.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M content/public/common/mojo_shell_connection.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/mock_render_thread.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/mock_render_thread.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M services/shell/public/cpp/connection.h View 2 chunks +1 line, -1 line 0 comments Download
M services/shell/public/cpp/interface_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/shell/public/cpp/lib/interface_provider.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 2099063002 Patch 100001

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100693002/80001
4 years, 5 months ago (2016-06-27 17:18:27 UTC) #2
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-06-27 18:05:16 UTC) #3
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/b4e2536de302ecbc29ad7a40fc124e15e7c74e77 Cr-Commit-Position: refs/heads/master@{#402225}
4 years, 5 months ago (2016-06-27 18:07:02 UTC) #5
tommycli
4 years, 5 months ago (2016-06-29 19:38:13 UTC) #6
Message was sent while issue was closed. 
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2107143003/ by tommycli@chromium.org.

The reason for reverting is: Speculatively reverting because this may have
broken Dr. Memory bots.

First breaking build:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%2...

Bot:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20(D....

Powered by Google App Engine
This is Rietveld 408576698