Mojo C++ Bindings: Extract AssociatedGroupController from MultiplexRouter

Mojo C++ Bindings: Extract AssociatedGroupController from MultiplexRouter

Defines AssociatedGroupController, an interface for managing
endpoint lifetime within an associated group. This was extracted
from MultiplexRouter which now implements the interface.

This is a precursor to supporting an alternative binding implementation
to serve the unique requirements of Mojo IPC::Channel and other
interfaces associated with it.

BUG=612500
Committed: https://crrev.com/3fe9ca703e3f2e72f8bcc641290935a181e3b022
Cr-Commit-Position: refs/heads/master@{#403230}

[Ken Rockot(use gerrit already), 2016-06-29 22:36:03]

rockot@chromium.org changed reviewers:
+ yzshen@chromium.org

[Ken Rockot(use gerrit already), 2016-06-29 22:36:43]

WDYT about landing this as is? I'm working on a follow-up CL which moves more
stuff out of internal, but thought it might be easier to keep separate.

[yzshen1, 2016-06-30 15:34:42]

LGTM

https://codereview.chromium.org/2100683002/diff/40001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/associated_group_controller.h (right):

https://codereview.chromium.org/2100683002/diff/40001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/associated_group_controller.h:49: // The returned
object is still owned by the router. It must only be used on
nit: router -> controller.

https://codereview.chromium.org/2100683002/diff/40001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/lib/multiplex_router.h (right):

https://codereview.chromium.org/2100683002/diff/40001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/lib/multiplex_router.h:135: friend class
base::RefCountedDeleteOnMessageLoop<MultiplexRouter>;
Is this one still necessary?

[Ken Rockot(use gerrit already), 2016-06-30 15:57:39]

Thanks!

https://codereview.chromium.org/2100683002/diff/40001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/associated_group_controller.h (right):

https://codereview.chromium.org/2100683002/diff/40001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/associated_group_controller.h:49: // The returned
object is still owned by the router. It must only be used on
On 2016/06/30 at 15:34:42, yzshen1 wrote:
> nit: router -> controller.

Done

https://codereview.chromium.org/2100683002/diff/40001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/lib/multiplex_router.h (right):

https://codereview.chromium.org/2100683002/diff/40001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/lib/multiplex_router.h:135: friend class
base::RefCountedDeleteOnMessageLoop<MultiplexRouter>;
On 2016/06/30 at 15:34:42, yzshen1 wrote:
> Is this one still necessary?

Nope, removed

[Ken Rockot(use gerrit already), 2016-06-30 15:57:39]

Thanks!

https://codereview.chromium.org/2100683002/diff/40001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/associated_group_controller.h (right):

https://codereview.chromium.org/2100683002/diff/40001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/associated_group_controller.h:49: // The returned
object is still owned by the router. It must only be used on
On 2016/06/30 at 15:34:42, yzshen1 wrote:
> nit: router -> controller.

Done

https://codereview.chromium.org/2100683002/diff/40001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/lib/multiplex_router.h (right):

https://codereview.chromium.org/2100683002/diff/40001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/lib/multiplex_router.h:135: friend class
base::RefCountedDeleteOnMessageLoop<MultiplexRouter>;
On 2016/06/30 at 15:34:42, yzshen1 wrote:
> Is this one still necessary?

Nope, removed

[Ken Rockot(use gerrit already), 2016-06-30 15:57:45]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-06-30 15:57:46]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2100683002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2016-06-30 15:58:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 16:29:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 16:29:16]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-06-30 16:50:02]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-06-30 16:50:03]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2100683002/#ps80001
(title: "gyp")

[commit-bot: I haz the power, 2016-06-30 16:50:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 17:23:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 17:23:29]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-06-30 17:31:58]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-06-30 17:31:58]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2100683002/#ps100001
(title: "oops more gyp ugh")

[commit-bot: I haz the power, 2016-06-30 17:33:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 17:38:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 17:38:15]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Ken Rockot(use gerrit already), 2016-06-30 17:45:06]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-06-30 17:45:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 17:50:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 17:50:07]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Ken Rockot(use gerrit already), 2016-06-30 18:15:34]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-06-30 18:16:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 18:36:28]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-30 18:36:42]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 18:38:07]

Description was changed from

==========
Mojo C++ Bindings: Extract AssociatedGroupController from MultiplexRouter

Defines AssociatedGroupController, an interface for managing
endpoint lifetime within an associated group. This was extracted
from MultiplexRouter which now implements the interface.

This is a precursor to supporting an alternative binding implementation
to serve the unique requirements of Mojo IPC::Channel and other
interfaces associated with it.

BUG=612500
==========

to

==========
Mojo C++ Bindings: Extract AssociatedGroupController from MultiplexRouter

Defines AssociatedGroupController, an interface for managing
endpoint lifetime within an associated group. This was extracted
from MultiplexRouter which now implements the interface.

This is a precursor to supporting an alternative binding implementation
to serve the unique requirements of Mojo IPC::Channel and other
interfaces associated with it.

BUG=612500

Committed: https://crrev.com/3fe9ca703e3f2e72f8bcc641290935a181e3b022
Cr-Commit-Position: refs/heads/master@{#403230}
==========

[commit-bot: I haz the power, 2016-06-30 18:38:08]

Patchset 6 (id:??) landed as
https://crrev.com/3fe9ca703e3f2e72f8bcc641290935a181e3b022
Cr-Commit-Position: refs/heads/master@{#403230}