Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: components/page_load_metrics/renderer/fake_page_timing_metrics_ipc_sender.cc

Issue 2100653002: PageLoadTiming fixes in prep for using base::Optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert changes to PageLoadTiming Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/renderer/fake_page_timing_metrics_ipc_sender.cc
diff --git a/components/page_load_metrics/renderer/fake_page_timing_metrics_ipc_sender.cc b/components/page_load_metrics/renderer/fake_page_timing_metrics_ipc_sender.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e1e8e54ecdb436a12a287076c56327e9aa1a1b25
--- /dev/null
+++ b/components/page_load_metrics/renderer/fake_page_timing_metrics_ipc_sender.cc
@@ -0,0 +1,54 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/page_load_metrics/common/page_load_metrics_messages.h"
+#include "components/page_load_metrics/renderer/fake_page_timing_metrics_ipc_sender.h"
+#include "ipc/ipc_message.h"
+#include "ipc/ipc_message_macros.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace page_load_metrics {
+
+FakePageTimingMetricsIPCSender::FakePageTimingMetricsIPCSender() {}
+
+FakePageTimingMetricsIPCSender::~FakePageTimingMetricsIPCSender() {
+ VerifyExpectedTimings();
+}
+
+void FakePageTimingMetricsIPCSender::ExpectPageLoadTiming(
+ const PageLoadTiming& timing) {
+ VerifyExpectedTimings();
+ expected_timings_.push_back(timing);
+}
+
+void FakePageTimingMetricsIPCSender::VerifyExpectedTimings() const {
+ // Ideally we'd just call ASSERT_EQ(actual_timings_, expected_timings_) here,
+ // but this causes the generated gtest code to fail to build on Windows. See
+ // the comments in the header file for additional details.
+ ASSERT_EQ(actual_timings_.size(), expected_timings_.size());
+ for (size_t i = 0; i < actual_timings_.size(); ++i) {
+ if (actual_timings_.at(i) == expected_timings_.at(i))
+ continue;
+ ADD_FAILURE() << "Actual timing != expected timing at index " << i;
+ }
+}
+
+bool FakePageTimingMetricsIPCSender::Send(IPC::Message* message) {
+ IPC_BEGIN_MESSAGE_MAP(FakePageTimingMetricsIPCSender, *message)
+ IPC_MESSAGE_HANDLER(PageLoadMetricsMsg_TimingUpdated, OnTimingUpdated)
+ IPC_MESSAGE_UNHANDLED(ADD_FAILURE())
+ IPC_END_MESSAGE_MAP()
+
+ delete message;
+ return true;
+}
+
+void FakePageTimingMetricsIPCSender::OnTimingUpdated(
+ const PageLoadTiming& timing,
+ PageLoadMetadata metadata) {
+ actual_timings_.push_back(timing);
+ VerifyExpectedTimings();
+}
+
+} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698