Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2100623002: [parser] report error for shorthand property "await" in async arrow formals (Closed)

Created:
4 years, 6 months ago by caitp (gmail)
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] report error for shorthand property "await" in async arrow formals In addition to recording the BindingPattern error, also record an AsyncArrowFormalParameters error for shorthand property "await" in object literals. BUG=v8:4483, v8:5148 R=littledan@chromium.org, jwolfe@igalia.com, adamk@chromium.org, nikolaos@chromium.org Committed: https://crrev.com/4efd20ab575b98ba531cbbcc55051f3d85657948 Cr-Commit-Position: refs/heads/master@{#37302}

Patch Set 1 #

Patch Set 2 : also test in preparser #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M src/parsing/parser-base.h View 1 chunk +10 lines, -4 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 1 chunk +3 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100623002/1
4 years, 6 months ago (2016-06-25 03:07:20 UTC) #2
caitp (gmail)
Here's a fix for the banned "await" identifier in async arrow formals. Apparently it was ...
4 years, 6 months ago (2016-06-25 03:09:08 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100623002/20001
4 years, 6 months ago (2016-06-25 14:32:06 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-25 14:54:57 UTC) #9
nickie
LGTM.
4 years, 5 months ago (2016-06-27 09:47:40 UTC) #10
Dan Ehrenberg
lgtm
4 years, 5 months ago (2016-06-27 19:46:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100623002/20001
4 years, 5 months ago (2016-06-27 20:43:34 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 21:11:42 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 21:12:31 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4efd20ab575b98ba531cbbcc55051f3d85657948
Cr-Commit-Position: refs/heads/master@{#37302}

Powered by Google App Engine
This is Rietveld 408576698