LayoutTests/fast/css/variables/cssom-computed-style.html - Issue 21006006: Add forEach() to CSSVariablesMap

Side by Side Diff: LayoutTests/fast/css/variables/cssom-computed-style.html

Issue 21006006: Add forEach() to CSSVariablesMap (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased onto callback change Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <script>	1 <script>

2 if (window.testRunner)	2 if (window.testRunner)

3 testRunner.dumpAsText();	3 testRunner.dumpAsText();

4 </script>	4 </script>

5	5

6 <style>	6 <style>

7 pre {	7 pre {

8 var-stylesheet: pass;	8 var-stylesheet: pass;

9 }	9 }

10 </style>	10 </style>

11	11

12 <body>	12 <body>

13	13

14 <pre style="var-inherited: pass"><pre id="pre" style="var-inline: pass"></pre></ pre>	14 <pre style="var-inherited: pass"><pre id="pre" style="var-inline: pass"></pre></ pre>

15	15

16 </body>	16 </body>

17	17

18 <script>	18 <script>

19 var pre = document.querySelector("#pre");	19 var pre = document.querySelector("#pre");

20 var preStyle = getComputedStyle(pre);	20 var preStyle = getComputedStyle(pre);

21 var bodyStyle = getComputedStyle(document.querySelector("body"));	21 var bodyStyle = getComputedStyle(document.querySelector("body"));

22 pre.innerText += "Computed variables declaration: " + preStyle.var + "\n";	22 pre.innerText += "Computed variables declaration: " + preStyle.var + "\n";

23	23

	24 pre.innerText += "Equal variables declaration objects on multiple accesses: ";

	25 pre.innerText += ((preStyle.var === preStyle.var) ? "pass": "fail") + "\n";
	esprehn 2013/09/12 01:13:42 This isn't a good test, you need to trigger a gc b This isn't a good test, you need to trigger a gc between the two calls to .var alancutter (OOO until 2018) 2013/09/13 03:06:14 This check was suggested by arv after I had been c Show quoted text On 2013/09/12 01:13:42, esprehn wrote: > This isn't a good test, you need to trigger a gc between the two calls to .var This check was suggested by arv after I had been creating new CSSVariablesMaps with each call to var. I agree that a GC needs to be done between calls however I don't think it's possible to accurately test that using Javascript alone. The comparison would require holding refs to the objects. It does test at the very least that new vars are not being instantiated unnecessarily.
	26

24 pre.innerText += "Create variable: ";	27 pre.innerText += "Create variable: ";

25 try {	28 try {

26 preStyle.var.set("create", "test");	29 preStyle.var.set("create", "test");

27 pre.innerText += "No exception thrown.\n";	30 pre.innerText += "No exception thrown.\n";

28 }	31 }

29 catch (exception) {	32 catch (exception) {

30 pre.innerText += exception + "\n";	33 pre.innerText += exception + "\n";

31 }	34 }

32	35

33 pre.innerText += "Count variables: " + preStyle.var.size + "\n";	36 pre.innerText += "Count variables: " + preStyle.var.size + "\n";

34 pre.innerText += "Count empty variables: " + bodyStyle.var.size + "\n";	37 pre.innerText += "Count empty variables: " + bodyStyle.var.size + "\n";

35 pre.innerText += "Read stylesheet variable: " + preStyle.var.get("stylesheet") + "\n";	38 pre.innerText += "Read stylesheet variable: " + preStyle.var.get("stylesheet") + "\n";

36 pre.innerText += "Read inherited variable: " + preStyle.var.get("inherited") + " \n";	39 pre.innerText += "Read inherited variable: " + preStyle.var.get("inherited") + " \n";

37 pre.innerText += "Read inline variable: " + preStyle.var.get("inline") + "\n";	40 pre.innerText += "Read inline variable: " + preStyle.var.get("inline") + "\n";

38 pre.innerText += "Read non-existent variable: " + (bodyStyle.var.get("test") ? " fail" : "pass") + "\n";	41 pre.innerText += "Read non-existent variable: " + (bodyStyle.var.get("test") ? " fail" : "pass") + "\n";

39	42

	43 pre.innerText += "Enumerate variables:\n";

	44 var varList = [];

	45 preStyle.var.forEach(function(value, name) { varList.push([name, value]); });

	46 varList.sort();

	47 for (var i = 0; i < varList.length; i++) {

	48 pre.innerText += " " + varList[i][0] + ": " + varList[i][1] + "\n";

	49 }

	50

	51 pre.innerText += "Enumerate empty variables: ";

	52 var pass = true;

	53 bodyStyle.var.forEach(function(value, name) { pass = false; });

	54 pre.innerText += (pass ? "pass" : "fail") + "\n";

	55

40 pre.innerText += "Update variable: ";	56 pre.innerText += "Update variable: ";

41 try {	57 try {

42 preStyle.var.set("inline", "test");	58 preStyle.var.set("inline", "test");

43 pre.innerText += "No exception thrown (fail).\n";	59 pre.innerText += "No exception thrown (fail).\n";

44 }	60 }

45 catch (exception) {	61 catch (exception) {

46 pre.innerText += exception + "\n";	62 pre.innerText += exception + "\n";

47 }	63 }

48	64

49 pre.innerText += "Delete variable: " + (preStyle.var.delete("inline") ? "Deleted " : "Not deleted") + "\n";	65 pre.innerText += "Delete variable: " + (preStyle.var.delete("inline") ? "Deleted " : "Not deleted") + "\n";

(...skipping 11 matching lines...) Expand all Loading...
61 try {	77 try {

62 preStyle.cssText = "yay: !important;";	78 preStyle.cssText = "yay: !important;";

63 pre.innerText += "No exception thrown (fail).\n";	79 pre.innerText += "No exception thrown (fail).\n";

64 }	80 }

65 catch (exception) {	81 catch (exception) {

66 pre.innerText += exception + "\n";	82 pre.innerText += exception + "\n";

67 }	83 }

68	84

69 pre.innerText += "Read deleted variable: " + preStyle.var.get("inline") + "\n";	85 pre.innerText += "Read deleted variable: " + preStyle.var.get("inline") + "\n";

70 </script>	86 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css/variables/cssom-computed-style-expected.txt » ('j') | LayoutTests/fast/css/variables/cssom-foreach.html » ('J')