Add forEach() to CSSVariablesMap

Source/bindings/scripts/code_generator_v8.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 191 matching lines @@
 
 
 def cpp_class_name(interface):
     return interface.extended_attributes.get('ImplementedAs', interface.name)
 
 
 def v8_class_name(interface):
     return v8_type(interface.name)
 
 
+def has_extended_attribute_value(extended_attributes, key, value):
+    return key in extended_attributes and value in extended_attribute_values(extended_attributes, key)
+
+
+def extended_attribute_values(extended_attributes, key):
+    if key not in extended_attributes:
+        return None
+    values_string = extended_attributes[key]
+    if not values_string:
+        return []
+    return re.split('[|&]', values_string)
+
+
 class CodeGeneratorV8:
     def __init__(self, definitions, interface_name, output_directory, relative_dir_posix, idl_directories, verbose=False):
         self.idl_definitions = definitions
         self.interface_name = interface_name
         self.idl_directories = idl_directories
         self.output_directory = output_directory
         self.relative_dir_posix = relative_dir_posix
         self.verbose = verbose
         self.interface = None
         self.header_includes = set()
@@ skipping 91 matching lines @@
 
         def generate_argument(argument):
             receiver = 'v8::Handle<v8::Value> %sHandle = %%s;' % argument.name
             cpp_to_js_conversion = self.generate_cpp_to_js_conversion(argument.data_type, argument.name, receiver, 'isolate', creation_context='v8::Handle<v8::Object>()')
             return {
                 'name': argument.name,
                 'cpp_to_js_conversion': cpp_to_js_conversion,
             }
 
         def generate_method(operation):
-            def argument_declaration(argument):
+            def generate_argument_declaration(argument):
                 return '%s %s' % (cpp_type(argument.data_type, 'raw'), argument.name)
 
+            call_with_this_handle = has_extended_attribute_value(operation.extended_attributes, 'CallWith', 'ThisValue')
             arguments = []
             custom = 'Custom' in operation.extended_attributes
             if not custom:
                 self.cpp_includes |= includes_for_operation(operation)
                 if operation.data_type != 'boolean':
                     raise Exception("We don't yet support callbacks that return non-boolean values.")
                 arguments = [generate_argument(argument) for argument in operation.arguments]
+            argument_declaration = ', '.join([generate_argument_declaration(argument) for argument in operation.arguments])

[arv (Not doing code reviews), 2013/08/08 14:24:51]

I was referring to the []. join takes an iterable and you are using an array
comprehension to build the array, just to then iterate over the array again. You
can, simply remove the [] from your code:

argument_declaration = ', '.join(generate_argument_declaration(argu
     ment) for argument in operation.arguments)

[alancutter (OOO until 2018), 2013/08/09 05:33:26]

I see now, that is better.
Done.

+            if call_with_this_handle:
+                argument_declaration = 'ScriptValue thisValue, ' + argument_declaration
             method = {
+                'call_with_this_handle': call_with_this_handle,
                 'return_cpp_type': cpp_type(operation.data_type, 'RefPtr'),
                 'name': operation.name,
                 'arguments': arguments,
-                'argument_declaration': ', '.join([argument_declaration(argument) for argument in operation.arguments]),
+                'argument_declaration': argument_declaration,
                 'handles': ', '.join(['%sHandle' % argument.name for argument in operation.arguments]),
                 'custom': custom,
             }
             return method
 
         methods = [generate_method(operation) for operation in self.interface.operations]
         template_contents = {
             'cpp_class_name': self.interface.name,
             'v8_class_name': v8_class_name(self.interface),
             'cpp_includes': sorted(list(self.cpp_includes)),
             'header_includes': sorted(list(self.header_includes)),
             'methods': methods,
         }
         return template_contents