LayoutTests/fast/css/variables/cssom-read.html - Issue 21006006: Add forEach() to CSSVariablesMap

Side by Side Diff: LayoutTests/fast/css/variables/cssom-read.html

Issue 21006006: Add forEach() to CSSVariablesMap (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Reverted .tmpl rename Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/fast/css/variables/cssom-computed-style.html ('K') | « LayoutTests/fast/css/variables/cssom-foreach-expected.txt ('k') | LayoutTests/fast/css/variables/cssom-read-expected.txt » ('j') | Source/bindings/scripts/code_generator_v8.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2	2

3 <pre style="var-a: override me; var-a: apple; var-b: banana;"></pre>	3 <pre style="var-a: override me; var-a: apple; var-b: banana;"></pre>

4	4

5 <script>	5 <script>

6 if (window.testRunner) {	6 if (window.testRunner) {

7 window.testRunner.dumpAsText();	7 window.testRunner.dumpAsText();

8 }	8 }

9	9

10 var pre = document.querySelector("pre");	10 var pre = document.querySelector("pre");

11	11

	12 function outputForEach (styleVar) {

	13 var varList = [];

	14 styleVar.forEach(function(value, name) { varList.push([name, value]); });
	arv (Not doing code reviews) 2013/08/07 14:16:23 Why not just print inside the forEach? No need for Why not just print inside the forEach? No need for temp varList: function outputForEach (styleVar) { styleVar.forEach(function(value, name) { pre.innerText += name + ": " + value + "\n"; }); } alancutter (OOO until 2018) 2013/08/08 01:50:57 Thanks for pointing this out, I didn't refactor af Show quoted text On 2013/08/07 14:16:23, arv wrote: > Why not just print inside the forEach? No need for temp varList: > > function outputForEach (styleVar) { > styleVar.forEach(function(value, name) { > pre.innerText += name + ": " + value + "\n"; > }); > } Thanks for pointing this out, I didn't refactor after removing varList.sort();
	15 for (var i = 0; i < varList.length; i++) {

	16 pre.innerText += varList[i][0] + ": " + varList[i][1] + "\n";

	17 }

	18 }

	19

	20 pre.innerText += "Equal variables declaration objects on multiple accesses: ";

	21 pre.innerText += ((pre.style.var === pre.style.var) ? "pass": "fail") + "\n";

	22 pre.innerText += "\n";

	23

12 pre.innerText += "Inline style CSS text: " + pre.style.cssText + "\n";	24 pre.innerText += "Inline style CSS text: " + pre.style.cssText + "\n";

13 pre.innerText += "\n";	25 pre.innerText += "\n";

14	26

15 pre.innerText += "Count vars: " + pre.style.var.size + "\n";	27 pre.innerText += "Count vars: " + pre.style.var.size + "\n";

16 pre.innerText += "\n";	28 pre.innerText += "\n";

17	29

18 pre.innerText += "Access vars directly:\n";	30 pre.innerText += "Access vars directly:\n";

19 pre.innerText += "a: " + pre.style.var.get("a") + "\n";	31 pre.innerText += "a: " + pre.style.var.get("a") + "\n";

20 pre.innerText += "b: " + pre.style.var.get("b") + "\n";	32 pre.innerText += "b: " + pre.style.var.get("b") + "\n";

21 pre.innerText += "\n";	33 pre.innerText += "\n";

22	34

	35 pre.innerText += "Enumerate vars:\n";

	36 outputForEach(pre.style.var);

	37 pre.innerText += "\n";

	38

23 pre.innerText += "Access non existent var:\n";	39 pre.innerText += "Access non existent var:\n";

24 pre.innerText += "z: " + pre.style.var.get("z") + "\n";	40 pre.innerText += "z: " + pre.style.var.get("z") + "\n";

25 pre.innerText += "\n";	41 pre.innerText += "\n";

26	42

27 pre.innerText += "Setting c to carrot and d to dog...\n";	43 pre.innerText += "Setting c to carrot and d to dog...\n";

28 pre.style.var.set("c", "carrot");	44 pre.style.var.set("c", "carrot");

29 pre.style.var.set("d", "dog");	45 pre.style.var.set("d", "dog");

30 pre.innerText += "\n";	46 pre.innerText += "\n";

31	47

32 pre.innerText += "Count vars: " + pre.style.var.size + "\n";	48 pre.innerText += "Count vars: " + pre.style.var.size + "\n";

33 pre.innerText += "\n";	49 pre.innerText += "\n";

34	50

35 pre.innerText += "Access vars directly:\n";	51 pre.innerText += "Access vars directly:\n";

36 pre.innerText += "a: " + pre.style.var.get("a") + "\n";	52 pre.innerText += "a: " + pre.style.var.get("a") + "\n";

37 pre.innerText += "b: " + pre.style.var.get("b") + "\n";	53 pre.innerText += "b: " + pre.style.var.get("b") + "\n";

38 pre.innerText += "c: " + pre.style.var.get("c") + "\n";	54 pre.innerText += "c: " + pre.style.var.get("c") + "\n";

39 pre.innerText += "d: " + pre.style.var.get("d") + "\n";	55 pre.innerText += "d: " + pre.style.var.get("d") + "\n";

	56 pre.innerText += "\n";

	57

	58 pre.innerText += "Enumerate vars:\n";

	59 outputForEach(pre.style.var);

40	60

41 </script>	61 </script>

OLD	NEW