LayoutTests/fast/css/variables/cssom-read.html - Issue 21006006: Add forEach() to CSSVariablesMap

Side by Side Diff: LayoutTests/fast/css/variables/cssom-read.html

Issue 21006006: Add forEach() to CSSVariablesMap (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/fast/css/variables/cssom-foreach.html ('K') | « LayoutTests/fast/css/variables/cssom-foreach-expected.txt ('k') | LayoutTests/fast/css/variables/cssom-read-expected.txt » ('j') | Source/core/css/CSSVariablesMap.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2	2

3 <pre style="var-a: override me; var-a: apple; var-b: banana;"></pre>	3 <pre style="var-a: override me; var-a: apple; var-b: banana;"></pre>

4	4

5 <script>	5 <script>

6 if (window.testRunner) {	6 if (window.testRunner) {

7 window.testRunner.dumpAsText();	7 window.testRunner.dumpAsText();

8 }	8 }

9	9

10 var pre = document.querySelector("pre");	10 var pre = document.querySelector("pre");

11	11

	12 function outputForEach (styleVar) {

	13 var varList = [];

	14 styleVar.forEach(function(value, name) { varList.push([name, value]); });

	15 varList.sort();
	arv (Not doing code reviews) 2013/07/31 16:45:24 Why are we sorting this. The order should be deter Why are we sorting this. The order should be deterministic already. alancutter (OOO until 2018) 2013/08/05 09:33:49 Done. Show quoted text On 2013/07/31 16:45:24, arv wrote: > Why are we sorting this. The order should be deterministic already. Done.
	16 for (var i in varList) {
	arv (Not doing code reviews) 2013/07/31 16:45:24 forEach or c style loop forEach or c style loop alancutter (OOO until 2018) 2013/08/05 09:33:49 Done. Show quoted text On 2013/07/31 16:45:24, arv wrote: > forEach or c style loop Done.
	17 pre.innerText += varList[i][0] + ": " + varList[i][1] + "\n";

	18 }

	19 }

	20

12 pre.innerText += "Count vars: " + pre.style.var.size + "\n";	21 pre.innerText += "Count vars: " + pre.style.var.size + "\n";

13 pre.innerText += "\n";	22 pre.innerText += "\n";

14	23

15 pre.innerText += "Access vars directly:\n";	24 pre.innerText += "Access vars directly:\n";

16 pre.innerText += "a: " + pre.style.var.get("a") + "\n";	25 pre.innerText += "a: " + pre.style.var.get("a") + "\n";

17 pre.innerText += "b: " + pre.style.var.get("b") + "\n";	26 pre.innerText += "b: " + pre.style.var.get("b") + "\n";

18 pre.innerText += "\n";	27 pre.innerText += "\n";

19	28

	29 pre.innerText += "Enumerate vars:\n";

	30 outputForEach(pre.style.var);

	31 pre.innerText += "\n";

	32

20 pre.innerText += "Access non existent var:\n";	33 pre.innerText += "Access non existent var:\n";

21 pre.innerText += "z: " + pre.style.var.get("z") + "\n";	34 pre.innerText += "z: " + pre.style.var.get("z") + "\n";

22 pre.innerText += "\n";	35 pre.innerText += "\n";

23	36

24 pre.innerText += "Setting c to carrot and d to dog...\n";	37 pre.innerText += "Setting c to carrot and d to dog...\n";

25 pre.style.var.set("c", "carrot");	38 pre.style.var.set("c", "carrot");

26 pre.style.var.set("d", "dog");	39 pre.style.var.set("d", "dog");

27 pre.innerText += "\n";	40 pre.innerText += "\n";

28	41

29 pre.innerText += "Count vars: " + pre.style.var.size + "\n";	42 pre.innerText += "Count vars: " + pre.style.var.size + "\n";

30 pre.innerText += "\n";	43 pre.innerText += "\n";

31	44

32 pre.innerText += "Access vars directly:\n";	45 pre.innerText += "Access vars directly:\n";

33 pre.innerText += "a: " + pre.style.var.get("a") + "\n";	46 pre.innerText += "a: " + pre.style.var.get("a") + "\n";

34 pre.innerText += "b: " + pre.style.var.get("b") + "\n";	47 pre.innerText += "b: " + pre.style.var.get("b") + "\n";

35 pre.innerText += "c: " + pre.style.var.get("c") + "\n";	48 pre.innerText += "c: " + pre.style.var.get("c") + "\n";

36 pre.innerText += "d: " + pre.style.var.get("d") + "\n";	49 pre.innerText += "d: " + pre.style.var.get("d") + "\n";

	50 pre.innerText += "\n";

	51

	52 pre.innerText += "Enumerate vars:\n";

	53 outputForEach(pre.style.var);

37	54

38 </script>	55 </script>

OLD	NEW