LayoutTests/fast/css/variables/cssom-computed-style.html - Issue 21006006: Add forEach() to CSSVariablesMap

Side by Side Diff: LayoutTests/fast/css/variables/cssom-computed-style.html

Issue 21006006: Add forEach() to CSSVariablesMap (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <script>	1 <script>

2 if (window.testRunner)	2 if (window.testRunner)
	arv (Not doing code reviews) 2013/07/31 16:45:24 Maybe you should switch to testharness.js or js-te Maybe you should switch to testharness.js or js-test-pre.js Ad-hoc tests are harder to maintain. alancutter (OOO until 2018) 2013/08/05 09:33:49 I agree with doing this. Perhaps change all variab Show quoted text On 2013/07/31 16:45:24, arv wrote: > Maybe you should switch to testharness.js or js-test-pre.js > > Ad-hoc tests are harder to maintain. I agree with doing this. Perhaps change all variables tests to use the test utils in a separate patch.
3 testRunner.dumpAsText();	3 testRunner.dumpAsText();

4 </script>	4 </script>

5	5

6 <style>	6 <style>

7 pre {	7 pre {

8 var-stylesheet: pass;	8 var-stylesheet: pass;

9 }	9 }

10 </style>	10 </style>

11	11

12 <body>	12 <body>

(...skipping 17 matching lines...) Expand all Loading...
30 pre.innerText += exception + "\n";	30 pre.innerText += exception + "\n";

31 }	31 }

32	32

33 pre.innerText += "Count variables: " + preStyle.var.size + "\n";	33 pre.innerText += "Count variables: " + preStyle.var.size + "\n";

34 pre.innerText += "Count empty variables: " + bodyStyle.var.size + "\n";	34 pre.innerText += "Count empty variables: " + bodyStyle.var.size + "\n";

35 pre.innerText += "Read stylesheet variable: " + preStyle.var.get("stylesheet") + "\n";	35 pre.innerText += "Read stylesheet variable: " + preStyle.var.get("stylesheet") + "\n";

36 pre.innerText += "Read inherited variable: " + preStyle.var.get("inherited") + " \n";	36 pre.innerText += "Read inherited variable: " + preStyle.var.get("inherited") + " \n";

37 pre.innerText += "Read inline variable: " + preStyle.var.get("inline") + "\n";	37 pre.innerText += "Read inline variable: " + preStyle.var.get("inline") + "\n";

38 pre.innerText += "Read non-existent variable: " + (bodyStyle.var.get("test") ? " fail" : "pass") + "\n";	38 pre.innerText += "Read non-existent variable: " + (bodyStyle.var.get("test") ? " fail" : "pass") + "\n";

39	39

	40 pre.innerText += "Enumerate variables:\n";
	arv (Not doing code reviews) 2013/07/31 16:45:24 don't use innerText... I know you are just followi don't use innerText... I know you are just following the pattern here so this is just an FYI for future code/tests. Did you know that every time you do "innerText +=" a layout is done? alancutter (OOO until 2018) 2013/08/05 09:33:49 Thanks for the advice. I'll avoid using it in futu Show quoted text On 2013/07/31 16:45:24, arv wrote: > don't use innerText... I know you are just following the pattern here so this is > just an FYI for future code/tests. > > Did you know that every time you do "innerText +=" a layout is done? Thanks for the advice. I'll avoid using it in future.
	41 var varList = [];

	42 preStyle.var.forEach(function(value, name) { varList.push([name, value]); });

	43 varList.sort();

	44 for (var i in varList) {
	arv (Not doing code reviews) 2013/07/31 16:45:24 do not use for-in loops to loop over arrays. Use f do not use for-in loops to loop over arrays. Use forEach or c style for loop. alancutter (OOO until 2018) 2013/08/05 09:33:49 Done. Show quoted text On 2013/07/31 16:45:24, arv wrote: > do not use for-in loops to loop over arrays. Use forEach or c style for loop. Done.
	45 pre.innerText += " " + varList[i][0] + ": " + varList[i][1] + "\n";

	46 }

	47

	48 pre.innerText += "Enumerate empty variables: ";

	49 var pass = true;

	50 bodyStyle.var.forEach(function(value, name) { pass = false; });

	51 pre.innerText += (pass ? "pass" : "fail") + "\n";

	52

40 pre.innerText += "Update variable: ";	53 pre.innerText += "Update variable: ";

41 try {	54 try {

42 preStyle.var.set("inline", "test");	55 preStyle.var.set("inline", "test");

43 pre.innerText += "No exception thrown (fail).\n";	56 pre.innerText += "No exception thrown (fail).\n";

44 }	57 }

45 catch (exception) {	58 catch (exception) {

46 pre.innerText += exception + "\n";	59 pre.innerText += exception + "\n";

47 }	60 }

48	61

49 pre.innerText += "Delete variable: " + (preStyle.var.delete("inline") ? "Deleted " : "Not deleted") + "\n";	62 pre.innerText += "Delete variable: " + (preStyle.var.delete("inline") ? "Deleted " : "Not deleted") + "\n";

50	63

51 pre.innerText += "Clear variables: ";	64 pre.innerText += "Clear variables: ";

52 try {	65 try {

53 preStyle.var.clear();	66 preStyle.var.clear();

54 pre.innerText += "No exception thrown (fail).\n";	67 pre.innerText += "No exception thrown (fail).\n";

55 }	68 }

56 catch (exception) {	69 catch (exception) {

57 pre.innerText += exception + "\n";	70 pre.innerText += exception + "\n";

58 }	71 }

59	72

60 pre.innerText += "Read deleted variable: " + preStyle.var.get("inline") + "\n";	73 pre.innerText += "Read deleted variable: " + preStyle.var.get("inline") + "\n";

61 </script>	74 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css/variables/cssom-computed-style-expected.txt » ('j') | LayoutTests/fast/css/variables/cssom-foreach.html » ('J')