third_party/WebKit/Source/core/css/parser/CSSTokenizerInputStream.h - Issue 2100573002: Avoid copying strings when parsing CSS colors on the slow path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSTokenizerInputStream.h

Issue 2100573002: Avoid copying strings when parsing CSS colors on the slow path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missing else. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp ('K') | « third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp ('k') | third_party/WebKit/Source/platform/graphics/Color.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSTokenizerInputStream.h

diff --git a/third_party/WebKit/Source/core/css/parser/CSSTokenizerInputStream.h b/third_party/WebKit/Source/core/css/parser/CSSTokenizerInputStream.h

index be79cc381a17d249434763cc40b42e0eaa80b9c0..8df5db7a18ae18be909a78fe67682ba6bbb31ff9 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSTokenizerInputStream.h

+++ b/third_party/WebKit/Source/core/css/parser/CSSTokenizerInputStream.h

@@ -44,6 +44,7 @@ public:

return offset;

}

+ unsigned length() const { return m_stringLength; }

unsigned offset() const { return std::min(m_offset, m_stringLength); }

StringView rangeAt(unsigned start, unsigned length) const;