Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2100533002: Last reference to a library may be through a top-level type. (Closed)

Created:
4 years, 5 months ago by rmacnak
Modified:
4 years, 5 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Last reference to a library may be through a top-level type. BUG=http://dartbug.com/26733 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/8f342605f3fa3458ae1278918200c60f53cf0ce5

Patch Set 1 #

Total comments: 2

Patch Set 2 : const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M runtime/vm/precompiler.cc View 1 1 chunk +20 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
4 years, 5 months ago (2016-06-24 22:39:47 UTC) #2
Florian Schneider
Lgtm https://codereview.chromium.org/2100533002/diff/1/runtime/vm/precompiler.cc File runtime/vm/precompiler.cc (right): https://codereview.chromium.org/2100533002/diff/1/runtime/vm/precompiler.cc#newcode1737 runtime/vm/precompiler.cc:1737: Class& top = Class::Handle(Z, lib.toplevel_class()); const
4 years, 5 months ago (2016-06-24 22:43:10 UTC) #3
rmacnak
https://codereview.chromium.org/2100533002/diff/1/runtime/vm/precompiler.cc File runtime/vm/precompiler.cc (right): https://codereview.chromium.org/2100533002/diff/1/runtime/vm/precompiler.cc#newcode1737 runtime/vm/precompiler.cc:1737: Class& top = Class::Handle(Z, lib.toplevel_class()); On 2016/06/24 22:43:10, Florian ...
4 years, 5 months ago (2016-06-24 22:45:19 UTC) #4
rmacnak
4 years, 5 months ago (2016-06-25 00:59:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8f342605f3fa3458ae1278918200c60f53cf0ce5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698