Issue 210053003: Add index check in DoAccessArgumentsAt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 210053003: Add index check in DoAccessArgumentsAt. (Closed)

Created:
6 years, 9 months ago by ulan

Modified:
6 years, 9 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add index check in DoAccessArgumentsAt. BUG=355523 LOG=N TEST=mjsunit/regress/regress-355523 R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20245

Patch Set 2 : Add test and int3 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -10 lines)			Patch
	M	src/x64/lithium-codegen-x64.cc	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-355523.js	View	1	1 chunk	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

PTAL https://codereview.chromium.org/210053003/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): https://codereview.chromium.org/210053003/diff/1/src/x64/lithium-codegen-x64.cc#newcode2924 src/x64/lithium-codegen-x64.cc:2924: __ movp(result, args.GetArgumentOperand(const_index)); This move is guarded by ...

6 years, 9 months ago (2014-03-24 15:43:09 UTC) #1

ulan

6 years, 9 months ago (2014-03-25 13:26:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20245 (presubmit successful).

Expand Messages | Collapse Messages

Issue 210053003: Add index check in DoAccessArgumentsAt. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add test and int3 #

Messages