Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1480)

Unified Diff: Source/devtools/front_end/TimelineOverviewPane.js

Issue 210053002: DevTools: merge MemoryStatistics.js and CountersGraph.js, extract DOMCountersGraph.js (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/MemoryStatistics.js ('k') | Source/devtools/front_end/TimelinePanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TimelineOverviewPane.js
diff --git a/Source/devtools/front_end/TimelineOverviewPane.js b/Source/devtools/front_end/TimelineOverviewPane.js
index 53382ce71ecbebccd85b7d723fe16c95070e0579..645c08938da0305749c92a6e75d243ef733f23ec 100644
--- a/Source/devtools/front_end/TimelineOverviewPane.js
+++ b/Source/devtools/front_end/TimelineOverviewPane.js
@@ -67,7 +67,7 @@ WebInspector.TimelineOverviewPane.prototype = {
},
/**
- * @param {!WebInspector.TimelineOverviewBase} overviewControl
+ * @param {!WebInspector.TimelineOverview} overviewControl
*/
setOverviewControl: function(overviewControl)
{
@@ -298,8 +298,42 @@ WebInspector.TimelineOverviewCalculator.prototype = {
}
/**
+ * @interface
+ */
+WebInspector.TimelineOverview = function(model)
+{
+}
+
+WebInspector.TimelineOverview.prototype = {
+ /**
+ * @param {?Element} parentElement
+ * @param {!Element=} insertBefore
+ */
+ show: function(parentElement, insertBefore) { },
+
+ update: function() { },
+
+ reset: function() { },
+
+ /**
+ * @param {number} windowLeft
+ * @param {number} windowRight
+ * @return {!{startTime: number, endTime: number}}
+ */
+ windowTimes: function(windowLeft, windowRight) { },
+
+ /**
+ * @param {number} startTime
+ * @param {number} endTime
+ * @return {!{left: number, right: number}}
+ */
+ windowBoundaries: function(startTime, endTime) { }
+}
+
+/**
* @constructor
* @extends {WebInspector.VBox}
+ * @implements {WebInspector.TimelineOverview}
* @param {!WebInspector.TimelineModel} model
*/
WebInspector.TimelineOverviewBase = function(model)
@@ -312,8 +346,14 @@ WebInspector.TimelineOverviewBase = function(model)
}
WebInspector.TimelineOverviewBase.prototype = {
- update: function() { },
- reset: function() { },
+ update: function()
+ {
+ this.resetCanvas();
+ },
+
+ reset: function()
+ {
+ },
/**
* @param {number} windowLeft
« no previous file with comments | « Source/devtools/front_end/MemoryStatistics.js ('k') | Source/devtools/front_end/TimelinePanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698