Issue 210053002: DevTools: merge MemoryStatistics.js and CountersGraph.js, extract DOMCountersGraph.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 210053002: DevTools: merge MemoryStatistics.js and CountersGraph.js, extract DOMCountersGraph.js (Closed)

Created:
6 years, 9 months ago by pfeldman

Modified:
6 years, 9 months ago

Reviewers:
alph, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

DevTools: merge MemoryStatistics.js and CountersGraph.js, extract DOMCountersGraph.js Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169857

Patch Set 1 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+518 lines, -526 lines)			Patch
M	Source/devtools/devtools.gypi	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	Source/devtools/front_end/CountersGraph.js	View	4 chunks	+393 lines, -77 lines	0 comments	Download
A	Source/devtools/front_end/DOMCountersGraph.js	View	1 chunk	+76 lines, -0 lines	0 comments	Download
D	Source/devtools/front_end/MemoryStatistics.js	View	1 chunk	+0 lines, -441 lines	0 comments	Download
M	Source/devtools/front_end/TimelineOverviewPane.js	View	3 chunks	+43 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/TimelinePanel.js	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/devtools/scripts/frontend_modules.json	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/210053002/20001

6 years, 9 months ago (2014-03-24 14:54:08 UTC) #4

Message was sent while issue was closed.

Change committed as 169857

Expand Messages | Collapse Messages