Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Unified Diff: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

Issue 2100513002: Delete more probably unused plugin code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebPluginContainerImpl.h ('k') | third_party/WebKit/public/web/WebPlugin.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
index ec3514dab68bc591e14c21fd27e207fac73475ef..e143f82c3b2cb286e6c726780332bc6684822dee 100644
--- a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
@@ -264,20 +264,6 @@ void WebPluginContainerImpl::setParentVisible(bool parentVisible)
m_webPlugin->updateVisibility(isVisible());
}
-void WebPluginContainerImpl::setParent(Widget* widget)
-{
- // We override this function so that if the plugin is windowed, we can call
- // NPP_SetWindow at the first possible moment. This ensures that
- // NPP_SetWindow is called before the manual load data is sent to a plugin.
- // If this order is reversed, Flash won't load videos.
dcheng 2016/06/24 22:57:26 As far as I can tell, it works now? I tried vimeo,
esprehn 2016/06/24 23:01:42 Pepper flash doesn't supported the windowed mode I
piman 2016/06/25 01:07:01 Right, Pepper is essentially a mix of windowed and
-
- Widget::setParent(widget);
- if (widget)
- reportGeometry();
- else if (m_webPlugin)
- m_webPlugin->containerDidDetachFromParent();
-}
-
void WebPluginContainerImpl::setPlugin(WebPlugin* plugin)
{
if (plugin == m_webPlugin)
« no previous file with comments | « third_party/WebKit/Source/web/WebPluginContainerImpl.h ('k') | third_party/WebKit/public/web/WebPlugin.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698