Delete more probably unused plugin code.

Delete more probably unused plugin code.

BUG=none
R=esprehn@chromium.org,piman@chromium.org

Committed: https://crrev.com/b5cbd76bf3dc2e0c5876ab3be3ce1929c6771ad5
Cr-Commit-Position: refs/heads/master@{#402050}

[dcheng, 2016-06-24 22:57:26]

linux_android failure looks unrelated. I think this removal is safe, but I'm not
100% sure...

https://codereview.chromium.org/2100513002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebPluginContainerImpl.cpp (left):

https://codereview.chromium.org/2100513002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebPluginContainerImpl.cpp:272: // If this order
is reversed, Flash won't load videos.
As far as I can tell, it works now? I tried vimeo, but if you have suggestions
for other Flash video sites, please let me know.

[esprehn, 2016-06-24 23:01:43]

Yeah those sync calls look very suspect, but I also think this was about NPAPI
plugins which don't exist anymore. Pepper doesn't support "windowed mode" where
you create a separate HWND on top.

https://codereview.chromium.org/2100513002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebPluginContainerImpl.cpp (left):

https://codereview.chromium.org/2100513002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebPluginContainerImpl.cpp:272: // If this order
is reversed, Flash won't load videos.
On 2016/06/24 at 22:57:26, dcheng wrote:
> As far as I can tell, it works now? I tried vimeo, but if you have suggestions
for other Flash video sites, please let me know.

Pepper flash doesn't supported the windowed mode I think.

[esprehn, 2016-06-24 23:01:45]

lgtm

[piman, 2016-06-25 01:07:02]

lgtm

https://codereview.chromium.org/2100513002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebPluginContainerImpl.cpp (left):

https://codereview.chromium.org/2100513002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebPluginContainerImpl.cpp:272: // If this order
is reversed, Flash won't load videos.
On 2016/06/24 23:01:42, esprehn wrote:
> On 2016/06/24 at 22:57:26, dcheng wrote:
> > As far as I can tell, it works now? I tried vimeo, but if you have
suggestions
> for other Flash video sites, please let me know.
> 
> Pepper flash doesn't supported the windowed mode I think.

Right, Pepper is essentially a mix of windowed and windowless, taking the best
of both. Anyway, I'm pretty sure we made sure that Pepper Flash wasn't subject
to this sort of ordering constraints. NPP_SetWindow was pretty critical for a
bunch of things in NPAPI, but the equivalent (PPP_Instance.DidChangeView) is
only relevant for display.

[dcheng, 2016-06-25 02:23:24]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-06-25 02:23:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-25 03:43:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-25 03:44:56]

Description was changed from

==========
Delete more probably unused plugin code.

BUG=none
R=esprehn@chromium.org,piman@chromium.org
==========

to

==========
Delete more probably unused plugin code.

BUG=none
R=esprehn@chromium.org,piman@chromium.org

Committed: https://crrev.com/b5cbd76bf3dc2e0c5876ab3be3ce1929c6771ad5
Cr-Commit-Position: refs/heads/master@{#402050}
==========

[commit-bot: I haz the power, 2016-06-25 03:44:58]

Patchset 1 (id:??) landed as
https://crrev.com/b5cbd76bf3dc2e0c5876ab3be3ce1929c6771ad5
Cr-Commit-Position: refs/heads/master@{#402050}