Fix file input dialog from out-of-process iframe.

Fix file input dialog from out-of-process iframe.

The initial CL that ported over file input dialogs to function from
out-of-process iframes used the incorrect method to check whether the
frame is hidden or not. This CL fixes this issue and adds a test to
ensure file input works end-to-end.

BUG=615575
Committed: https://crrev.com/39e3eb7e848610bf9527bc648e4bd46fe59d4eda
Cr-Commit-Position: refs/heads/master@{#402007}

[nasko, 2016-06-24 21:36:58]

nasko@chromium.org changed reviewers:
+ creis@chromium.org

[nasko, 2016-06-24 21:36:59]

Hey Charlie,
Can you review this CL for me? I made a stupid mistake checking the RV hidden
state, where I should've changed it to be the RF state. This CL fixes this and
adds a test case to ensure it continues working.
Thanks in advance!
Nasko

[Charlie Reis, 2016-06-24 21:41:41]

Thanks, LGTM!  (Presumably the test fails without the fix?)

https://codereview.chromium.org/2100503002/diff/1/content/browser/site_per_pr...
File content/browser/site_per_process_browsertest.cc (right):

https://codereview.chromium.org/2100503002/diff/1/content/browser/site_per_pr...
content/browser/site_per_process_browsertest.cc:7308: WebContentsImpl* contents
= web_contents();
nit: This is unnecessary.  The other tests have it out of legacy reasons, before
web_contents() was added.

[nasko, 2016-06-24 22:11:24]

Yes, the test fails without the fix. I added the extra step of asking the
renderer process for the file name to ensure all IPCs are flowing as expected.

https://codereview.chromium.org/2100503002/diff/1/content/browser/site_per_pr...
File content/browser/site_per_process_browsertest.cc (right):

https://codereview.chromium.org/2100503002/diff/1/content/browser/site_per_pr...
content/browser/site_per_process_browsertest.cc:7308: WebContentsImpl* contents
= web_contents();
On 2016/06/24 21:41:41, Charlie Reis (slow) wrote:
> nit: This is unnecessary.  The other tests have it out of legacy reasons,
before
> web_contents() was added.

Done.

[nasko, 2016-06-24 22:11:36]

The CQ bit was checked by nasko@chromium.org

[nasko, 2016-06-24 22:11:37]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2100503002/#ps20001
(title: "Fix nit.")

[commit-bot: I haz the power, 2016-06-24 22:12:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 23:15:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-24 23:18:12]

Description was changed from

==========
Fix file input dialog from out-of-process iframe.

The initial CL that ported over file input dialogs to function from
out-of-process iframes used the incorrect method to check whether the
frame is hidden or not. This CL fixes this issue and adds a test to
ensure file input works end-to-end.

BUG=615575
==========

to

==========
Fix file input dialog from out-of-process iframe.

The initial CL that ported over file input dialogs to function from
out-of-process iframes used the incorrect method to check whether the
frame is hidden or not. This CL fixes this issue and adds a test to
ensure file input works end-to-end.

BUG=615575

Committed: https://crrev.com/39e3eb7e848610bf9527bc648e4bd46fe59d4eda
Cr-Commit-Position: refs/heads/master@{#402007}
==========

[commit-bot: I haz the power, 2016-06-24 23:18:13]

Patchset 2 (id:??) landed as
https://crrev.com/39e3eb7e848610bf9527bc648e4bd46fe59d4eda
Cr-Commit-Position: refs/heads/master@{#402007}