Issue 2100453003: msvs: Allow target platform version without WinRT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2100453003: msvs: Allow target platform version without WinRT (Closed)

Created:
4 years, 6 months ago by cwillisf

Modified:
4 years, 1 month ago

Reviewers:
Dirk Pranke

CC:
gyp-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/gyp.git@master

Target Ref:
refs/heads/master

Project:
gyp

Visibility:
Public.

msvs: Allow target platform version without WinRT This change makes the msvs_target_platform_{version,minversion} settings useful even when msvs_enable_winrt is not specified. This is needed for native code which uses the Windows Runtime C++ Template Library (WRL), for example. R=dpranke@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/ef2f29a7311bc6e881c1db4a40e881fd393fb255

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	pylib/gyp/generator/msvs.py	View		2 chunks	+12 lines, -12 lines	0 comments	Download

Total messages: 4 (2 generated)

Dirk Pranke

4 years, 1 month ago (2016-11-05 22:14:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ef2f29a7311bc6e881c1db4a40e881fd393fb255.