Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: content/browser/cache_storage/cache_storage_dispatcher_host.cc

Issue 2100433003: [CacheStorage] Temporarily preserve recently opened caches from CacheStorageDispatcherHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simplified Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/cache_storage/cache_storage_dispatcher_host.cc
diff --git a/content/browser/cache_storage/cache_storage_dispatcher_host.cc b/content/browser/cache_storage/cache_storage_dispatcher_host.cc
index e3ab6fa7faf33cfdeeac9fc64716b046ba1e959a..e9d748c16bb7fb01f154cc94154665a76de506cf 100644
--- a/content/browser/cache_storage/cache_storage_dispatcher_host.cc
+++ b/content/browser/cache_storage/cache_storage_dispatcher_host.cc
@@ -12,6 +12,8 @@
#include "base/macros.h"
#include "base/strings/string16.h"
#include "base/strings/utf_string_conversions.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "base/time/time.h"
#include "base/trace_event/trace_event.h"
#include "content/browser/bad_message.h"
#include "content/browser/cache_storage/cache_storage_cache.h"
@@ -31,6 +33,7 @@ namespace content {
namespace {
const uint32_t kFilteredMessageClasses[] = {CacheStorageMsgStart};
+const int32_t kCachePreservationSeconds = 5;
blink::WebServiceWorkerCacheError ToWebServiceWorkerCacheError(
CacheStorageError err) {
@@ -59,12 +62,14 @@ bool OriginCanAccessCacheStorage(const url::Origin& origin) {
return !origin.unique() && IsOriginSecure(GURL(origin.Serialize()));
}
+void StopPreservingCache(
+ std::unique_ptr<CacheStorageCacheHandle> cache_handle) {}
+
} // namespace
CacheStorageDispatcherHost::CacheStorageDispatcherHost()
: BrowserMessageFilter(kFilteredMessageClasses,
- arraysize(kFilteredMessageClasses)) {
-}
+ arraysize(kFilteredMessageClasses)) {}
CacheStorageDispatcherHost::~CacheStorageDispatcherHost() {
}
@@ -354,6 +359,14 @@ void CacheStorageDispatcherHost::OnCacheStorageOpenCallback(
thread_id, request_id, ToWebServiceWorkerCacheError(error)));
return;
}
+
+ // Hang on to the cache for a few seconds. This way if the user quickly closes
+ // and reopens it the cache backend won't have to be reinitialized.
+ base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
+ FROM_HERE,
+ base::Bind(&StopPreservingCache, base::Passed(cache_handle->Clone())),
+ base::TimeDelta::FromSeconds(kCachePreservationSeconds));
+
CacheID cache_id = StoreCacheReference(std::move(cache_handle));
Send(new CacheStorageMsg_CacheStorageOpenSuccess(thread_id, request_id,
cache_id));
« no previous file with comments | « content/browser/cache_storage/cache_storage.cc ('k') | content/browser/cache_storage/cache_storage_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698