Source/core/rendering/RenderBox.h - Issue 210043008: Kill outlineBox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.h

Issue 210043008: Kill outlineBox (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLAreaElement.cpp ('K') | « Source/core/rendering/LayoutRepainter.cpp ('k') | Source/core/rendering/RenderBox.cpp » ('j') | Source/core/rendering/RenderObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBox.h

diff --git a/Source/core/rendering/RenderBox.h b/Source/core/rendering/RenderBox.h

index d546a06a66bc5e72f18b50919096123a69aa30e0..2889c88bcc14bf7858a8b93dd1c4b073ef4e2e4a 100644

--- a/Source/core/rendering/RenderBox.h

+++ b/Source/core/rendering/RenderBox.h

@@ -193,7 +193,6 @@ public:

LayoutRect computedCSSContentBoxRect() const { return LayoutRect(borderLeft() + computedCSSPaddingLeft(), borderTop() + computedCSSPaddingTop(), clientWidth() - computedCSSPaddingLeft() - computedCSSPaddingRight(), clientHeight() - computedCSSPaddingTop() - computedCSSPaddingBottom()); }

// Bounds of the outline box in absolute coords. Respects transforms

leviw_travelin_and_unemployed 2014/03/25 04:40:58 You missed the comment :)

Julien - ping for review 2014/03/25 21:52:34 Done.

- virtual LayoutRect outlineBoundsForRepaint(const RenderLayerModelObject* /*repaintContainer*/, const RenderGeometryMap*) const OVERRIDE FINAL;

virtual void addFocusRingRects(Vector<IntRect>&, const LayoutPoint& additionalOffset, const RenderLayerModelObject* paintContainer = 0) OVERRIDE;

// Use this with caution! No type checking is done!

« Source/core/html/HTMLAreaElement.cpp ('K') | « Source/core/rendering/LayoutRepainter.cpp ('k') | Source/core/rendering/RenderBox.cpp » ('j') | Source/core/rendering/RenderObject.cpp » ('J')