Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: Source/core/rendering/RenderLayer.cpp

Issue 210043008: Kill outlineBox (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaselined patch, hoping it would solve the bot failure I can't reproduce locally Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderLayerRepainter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 494 matching lines...) Expand 10 before | Expand all | Expand 10 after
505 if ((flags & IsOverflowScroll) && (flags & HasSeenAncestorWithOverflowClip) && !m_canSkipRepaintRectsUpdateOnScroll) { 505 if ((flags & IsOverflowScroll) && (flags & HasSeenAncestorWithOverflowClip) && !m_canSkipRepaintRectsUpdateOnScroll) {
506 // FIXME: This may not be needed. Once repaint-after-layout isn't 506 // FIXME: This may not be needed. Once repaint-after-layout isn't
507 // under-painting for layer's we should see if this can be removed. 507 // under-painting for layer's we should see if this can be removed.
508 LayoutRectRecorder recorder(*m_renderer); 508 LayoutRectRecorder recorder(*m_renderer);
509 // FIXME: We could track the repaint container as we walk down the tree. 509 // FIXME: We could track the repaint container as we walk down the tree.
510 repainter().computeRepaintRects(renderer()->containerForRepaint(), geome tryMap); 510 repainter().computeRepaintRects(renderer()->containerForRepaint(), geome tryMap);
511 } else { 511 } else {
512 // Check that RenderLayerRepainter's cached rects are correct. 512 // Check that RenderLayerRepainter's cached rects are correct.
513 // FIXME: re-enable these assertions when the issue with table cells is resolved: https://bugs.webkit.org/show_bug.cgi?id=103432 513 // FIXME: re-enable these assertions when the issue with table cells is resolved: https://bugs.webkit.org/show_bug.cgi?id=103432
514 // ASSERT(repainter().m_repaintRect == renderer()->clippedOverflowRectFo rRepaint(renderer()->containerForRepaint())); 514 // ASSERT(repainter().m_repaintRect == renderer()->clippedOverflowRectFo rRepaint(renderer()->containerForRepaint()));
515 // ASSERT(repainter().m_outlineBox == renderer()->outlineBoundsForRepain t(renderer()->containerForRepaint(), geometryMap));
516 } 515 }
517 516
518 for (RenderLayer* child = firstChild(); child; child = child->nextSibling()) 517 for (RenderLayer* child = firstChild(); child; child = child->nextSibling())
519 child->updateLayerPositionsAfterScroll(geometryMap, flags); 518 child->updateLayerPositionsAfterScroll(geometryMap, flags);
520 519
521 // We don't update our reflection as scrolling is a translation which does n ot change the size() 520 // We don't update our reflection as scrolling is a translation which does n ot change the size()
522 // of an object, thus RenderReplica will still repaint itself properly as th e layer position was 521 // of an object, thus RenderReplica will still repaint itself properly as th e layer position was
523 // updated above. 522 // updated above.
524 523
525 if (geometryMap) 524 if (geometryMap)
(...skipping 3651 matching lines...) Expand 10 before | Expand all | Expand 10 after
4177 } 4176 }
4178 } 4177 }
4179 4178
4180 void showLayerTree(const WebCore::RenderObject* renderer) 4179 void showLayerTree(const WebCore::RenderObject* renderer)
4181 { 4180 {
4182 if (!renderer) 4181 if (!renderer)
4183 return; 4182 return;
4184 showLayerTree(renderer->enclosingLayer()); 4183 showLayerTree(renderer->enclosingLayer());
4185 } 4184 }
4186 #endif 4185 #endif
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderLayerRepainter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698