Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 210043008: Kill outlineBox (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaselined patch, hoping it would solve the bot failure I can't reproduce locally Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1041 matching lines...) Expand 10 before | Expand all | Expand 10 after
1052 // That call should be broken apart to position the layers be done befor e 1052 // That call should be broken apart to position the layers be done befor e
1053 // the repaintTree call so this will repaint everything. 1053 // the repaintTree call so this will repaint everything.
1054 bool didFullRepaint = false; 1054 bool didFullRepaint = false;
1055 if (!renderer->layoutDidGetCalled()) { 1055 if (!renderer->layoutDidGetCalled()) {
1056 if (renderer->shouldDoFullRepaintAfterLayout()) { 1056 if (renderer->shouldDoFullRepaintAfterLayout()) {
1057 renderer->repaint(); 1057 renderer->repaint();
1058 didFullRepaint = true; 1058 didFullRepaint = true;
1059 } 1059 }
1060 1060
1061 } else { 1061 } else {
1062 LayoutRect oldOutlineRect;
1063 LayoutRect newOutlineRect;
1064
1065 if (renderer->hasOutline()) {
1066 newOutlineRect = renderer->newOutlineRect();
1067 oldOutlineRect = renderer->oldOutlineRect();
1068 }
1069
1070 didFullRepaint = renderer->repaintAfterLayoutIfNeeded(renderer->cont ainerForRepaint(), 1062 didFullRepaint = renderer->repaintAfterLayoutIfNeeded(renderer->cont ainerForRepaint(),
1071 renderer->shouldDoFullRepaintAfterLayout(), oldRepaintRect, oldO utlineRect, 1063 renderer->shouldDoFullRepaintAfterLayout(), oldRepaintRect, &new RepaintRect);
1072 &newRepaintRect, &newOutlineRect);
1073 } 1064 }
1074 1065
1075 if (!didFullRepaint) 1066 if (!didFullRepaint)
1076 renderer->repaintOverflowIfNeeded(); 1067 renderer->repaintOverflowIfNeeded();
1077 1068
1078 // Repaint any scrollbars if there is a scrollable area for this rendere r. 1069 // Repaint any scrollbars if there is a scrollable area for this rendere r.
1079 if (renderer->enclosingLayer()) { 1070 if (renderer->enclosingLayer()) {
1080 if (RenderLayerScrollableArea* area = renderer->enclosingLayer()->sc rollableArea()) { 1071 if (RenderLayerScrollableArea* area = renderer->enclosingLayer()->sc rollableArea()) {
1081 if (area->hasVerticalBarDamage()) 1072 if (area->hasVerticalBarDamage())
1082 renderer->repaintRectangle(area->verticalBarDamage()); 1073 renderer->repaintRectangle(area->verticalBarDamage());
(...skipping 2173 matching lines...) Expand 10 before | Expand all | Expand 10 after
3256 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) 3247 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation)
3257 { 3248 {
3258 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); 3249 ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
3259 if (AXObjectCache* cache = axObjectCache()) { 3250 if (AXObjectCache* cache = axObjectCache()) {
3260 cache->remove(scrollbar); 3251 cache->remove(scrollbar);
3261 cache->handleScrollbarUpdate(this); 3252 cache->handleScrollbarUpdate(this);
3262 } 3253 }
3263 } 3254 }
3264 3255
3265 } // namespace WebCore 3256 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/platform/win/fast/repaint/table-collapsed-border-expected.txt ('k') | Source/core/html/HTMLAreaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698