Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2100393003: X87: [wasm] Separate compilation from instantiation. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [wasm] Separate compilation from instantiation. port c1d01aea117c62759cc2be1805493ed59218558c (r37086) original commit message: Compilation of wasm functions happens before instantiation. Imports are linked afterwards, at instantiation time. Globals and memory are also allocated and then tied in via relocation at instantiation time. This paves the way for implementing Wasm.compile, a prerequisite to offering the compiled code serialization feature. Currently, the WasmModule::Compile method just returns a fixed array containing the code objects. More appropriate modeling of the compiled module to come. Opportunistically centralized the logic on how to update memory references, size, and globals, since that logic is the exact same on each architecture, except for the actual storing of values back in the instruction stream. BUG= Committed: https://crrev.com/fe70bda483d83d1dcd17b403ca80f1b3ae797c53 Cr-Commit-Position: refs/heads/master@{#37307}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -36 lines) Patch
M src/x87/assembler-x87.cc View 1 chunk +6 lines, -36 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-06-28 02:05:46 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-06-28 02:45:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100393003/1
4 years, 5 months ago (2016-06-28 04:38:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 05:02:46 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 05:03:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe70bda483d83d1dcd17b403ca80f1b3ae797c53
Cr-Commit-Position: refs/heads/master@{#37307}

Powered by Google App Engine
This is Rietveld 408576698