Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 2100363002: Improve message in tool/test.sh (Closed)

Created:
4 years, 5 months ago by andrewkrieger
Modified:
4 years, 5 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve message in tool/test.sh New message instructs developers to run tool/browser_test.sh in order to actually run tests. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/91b1afe8d2a243e83a159b978615a26b0a8aa424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tool/test.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
andrewkrieger
4 years, 5 months ago (2016-06-27 22:35:17 UTC) #2
Jennifer Messerly
LGTM!
4 years, 5 months ago (2016-06-28 00:24:34 UTC) #3
andrewkrieger
4 years, 5 months ago (2016-06-28 00:40:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
91b1afe8d2a243e83a159b978615a26b0a8aa424 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698