Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2100343002: Calc overflow on positioned descendants of tables (Closed)

Created:
4 years, 5 months ago by rhogan
Modified:
4 years, 5 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@621612-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Calc overflow on the positioned descendants of tables Tables can be the containing block for positioned objects too, so when we take over the overflow calc duties from LayoutBlock we need to cater for positioned objects like it does too. I also spotted an error in LayoutTable::recalcChildOverflowAfterStyleChange() - we need to recalc overflow for all sections regardless of whether a section has already changed its overflow. BUG=619510 Committed: https://crrev.com/488de59908c1faab11124da600aabd5708df6e75 Cr-Commit-Position: refs/heads/master@{#402626}

Patch Set 1 #

Patch Set 2 : bug 619510 #

Patch Set 3 : bug 619510 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/repaint/input-overflow-in-table.html View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/repaint/input-overflow-in-table-expected.html View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/repaint/input-overflow-in-table-expected.txt View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
rhogan
4 years, 5 months ago (2016-06-28 17:55:56 UTC) #4
Xianzhu
lgtm
4 years, 5 months ago (2016-06-28 18:00:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100343002/20001
4 years, 5 months ago (2016-06-28 18:00:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/251621)
4 years, 5 months ago (2016-06-28 19:58:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100343002/40001
4 years, 5 months ago (2016-06-28 21:10:46 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-29 00:57:40 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 00:59:26 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/488de59908c1faab11124da600aabd5708df6e75
Cr-Commit-Position: refs/heads/master@{#402626}

Powered by Google App Engine
This is Rietveld 408576698