Issue 210033008: Don't include trailing comments in javascript snippets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 210033008: Don't include trailing comments in javascript snippets. (Closed)

Created:
6 years, 9 months ago by Tom Sepez

Modified:
6 years, 9 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Don't include trailing comment characters in javascript snippets. This trailing "/*" (and so forth) do not contribute very much to the signal, and not using them allows us to catch some interesting corner cases involving server-side page post-processors. BUG=355479 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169967

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -8 lines)			Patch
A +	LayoutTests/http/tests/security/xssAuditor/script-tag-with-injected-comment.html	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	LayoutTests/http/tests/security/xssAuditor/script-tag-with-injected-comment-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/parser/XSSAuditor.cpp	View	1	1 chunk	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/210033008/20001

6 years, 9 months ago (2014-03-25 17:05:06 UTC) #4

Message was sent while issue was closed.

Change committed as 169967

Expand Messages | Collapse Messages