[Mac][Material Design] Fix regression with initial bookmark bar text.

[Mac][Material Design] Fix regression with initial bookmark bar text.

[Mac][Material Design] Fix regression with initial bookmark bar text.

When you have an empty bookmarks bar, the bar displays a message about
adding bookmarks. With the switch to Material Design and the addition
of an NSVisualEffectView, the textfields' opaque ancestor was no
longer opaque, messing up subpixel anti-aliasing.

This cl changes the BookmarkBarToolbarView's isOpaque: method to
always return YES. The BookmarkBarToolbarView was in fact always
opaque, so returning YES is correct. Doing so causes the
BookmarkBarToolbarView's to be the textfields' opaque ancestor,
leading to correctly-drawn text.

R=tapted@chromium.org
BUG=617550, 617856
Review-Url: https://codereview.chromium.org/2061353002
Cr-Commit-Position: refs/heads/master@{#401391}
(cherry picked from commit eadf1aa099669f7a232ee8deed94d5b9d2da14a8)

Committed: https://chromium.googlesource.com/chromium/src/+/d5825147fa986abde5d2a293d06d1cac8ac8314e

[shrike, 2016-06-27 22:30:28]

Description was changed from

==========
[Mac][Material Design] Fix regression with initial bookmark bar text.

[Mac][Material Design] Fix regression with initial bookmark bar text.

When you have an empty bookmarks bar, the bar displays a message about
adding bookmarks. With the switch to Material Design and the addition
of an NSVisualEffectView, the textfields' opaque ancestor was no
longer opaque, messing up subpixel anti-aliasing.

This cl changes the BookmarkBarToolbarView's isOpaque: method to
always return YES. The BookmarkBarToolbarView was in fact always
opaque, so returning YES is correct. Doing so causes the
BookmarkBarToolbarView's to be the textfields' opaque ancestor,
leading to correctly-drawn text.

R=tapted@chromium.org
BUG=617550,617856

Review-Url: https://codereview.chromium.org/2061353002
Cr-Commit-Position: refs/heads/master@{#401391}
(cherry picked from commit eadf1aa099669f7a232ee8deed94d5b9d2da14a8)
==========

to

==========
[Mac][Material Design] Fix regression with initial bookmark bar text.

[Mac][Material Design] Fix regression with initial bookmark bar text.

When you have an empty bookmarks bar, the bar displays a message about
adding bookmarks. With the switch to Material Design and the addition
of an NSVisualEffectView, the textfields' opaque ancestor was no
longer opaque, messing up subpixel anti-aliasing.

This cl changes the BookmarkBarToolbarView's isOpaque: method to
always return YES. The BookmarkBarToolbarView was in fact always
opaque, so returning YES is correct. Doing so causes the
BookmarkBarToolbarView's to be the textfields' opaque ancestor,
leading to correctly-drawn text.

R=tapted@chromium.org
BUG=617550,617856

Review-Url: https://codereview.chromium.org/2061353002
Cr-Commit-Position: refs/heads/master@{#401391}
(cherry picked from commit eadf1aa099669f7a232ee8deed94d5b9d2da14a8)

Committed:
https://chromium.googlesource.com/chromium/src/+/d5825147fa986abde5d2a293d06d...
==========

[shrike, 2016-06-27 22:30:30]

Committed patchset #1 (id:1) manually as
d5825147fa986abde5d2a293d06d1cac8ac8314e.