Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2100313003: bluetooth: Remove Context from Wrappers and use LocationUtils directly (Closed)

Created:
4 years, 5 months ago by ortuno
Modified:
4 years, 5 months ago
Reviewers:
Ted C, scheib
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bluetooth-location-utils
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Remove Context from Wrappers and use LocationUtils directly Context is not final so there is no need to create a wrapper for it. We extend MockContext directly in our fakes. Adds a new setHasAndroidLocationPermission that sets a new factory for LocationUtils to return true or false. Follow up patch of http://crrev.com/2038753004 Committed: https://crrev.com/5966ddbd6d38eba46253350308f1bb59d1d467ab Cr-Commit-Position: refs/heads/master@{#403390}

Patch Set 1 #

Patch Set 2 : Change signature #

Patch Set 3 : Fix deps #

Patch Set 4 : remove new line #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -49 lines) Patch
M device/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothAdapter.java View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java View 6 chunks +4 lines, -31 lines 1 comment Download
A + device/bluetooth/test/android/java/DEPS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java View 1 3 4 chunks +32 lines, -15 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_android.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100313003/20001
4 years, 5 months ago (2016-06-27 22:04:49 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/236279)
4 years, 5 months ago (2016-06-27 23:18:59 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100313003/60001
4 years, 5 months ago (2016-06-29 21:35:24 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/96244)
4 years, 5 months ago (2016-06-29 23:13:58 UTC) #8
ortuno
scheib: PTAL
4 years, 5 months ago (2016-06-30 14:16:36 UTC) #10
scheib
LGTM https://codereview.chromium.org/2100313003/diff/60001/device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java File device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java (right): https://codereview.chromium.org/2100313003/diff/60001/device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java#newcode151 device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java:151: /** This is just spiffy, thanks for noticing.
4 years, 5 months ago (2016-06-30 20:52:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100313003/60001
4 years, 5 months ago (2016-06-30 20:59:06 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/210831)
4 years, 5 months ago (2016-06-30 21:10:06 UTC) #15
ortuno
tedchoc: Please take a look for owners of new DEPS.
4 years, 5 months ago (2016-06-30 21:28:37 UTC) #17
Ted C
On 2016/06/30 21:28:37, ortuno wrote: > tedchoc: Please take a look for owners of new ...
4 years, 5 months ago (2016-07-01 00:24:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100313003/60001
4 years, 5 months ago (2016-07-01 00:44:26 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-01 02:07:43 UTC) #21
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 02:09:56 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5966ddbd6d38eba46253350308f1bb59d1d467ab
Cr-Commit-Position: refs/heads/master@{#403390}

Powered by Google App Engine
This is Rietveld 408576698