Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: net/cert/internal/parse_ocsp.cc

Issue 2100303002: Add OCSPVerifyResult for tracking stapled OCSP responses cross-platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ocsp-date-check
Patch Set: Remaining nits. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/parse_ocsp.h ('k') | net/cert/internal/parse_ocsp_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/parse_ocsp.cc
diff --git a/net/cert/internal/parse_ocsp.cc b/net/cert/internal/parse_ocsp.cc
index 21ce878b3cfc78b7b3f9a894850e6024eb579bf2..3153b33008d8ea32aed02ae4bdf3e0c7dbcf429f 100644
--- a/net/cert/internal/parse_ocsp.cc
+++ b/net/cert/internal/parse_ocsp.cc
@@ -128,13 +128,13 @@ bool ParseCertStatus(const der::Input& raw_tlv, OCSPCertStatus* out) {
out->has_reason = false;
if (status_tag == der::ContextSpecificPrimitive(0)) {
- out->status = OCSPCertStatus::Status::GOOD;
+ out->status = OCSPRevocationStatus::GOOD;
} else if (status_tag == der::ContextSpecificConstructed(1)) {
- out->status = OCSPCertStatus::Status::REVOKED;
+ out->status = OCSPRevocationStatus::REVOKED;
if (!ParseRevokedInfo(status, out))
return false;
} else if (status_tag == der::ContextSpecificPrimitive(2)) {
- out->status = OCSPCertStatus::Status::UNKNOWN;
+ out->status = OCSPRevocationStatus::UNKNOWN;
} else {
return false;
}
@@ -497,7 +497,7 @@ bool GetOCSPCertStatus(const OCSPResponseData& response_data,
const der::Input& issuer_tbs_certificate_tlv,
const der::Input& cert_tbs_certificate_tlv,
OCSPCertStatus* out) {
- out->status = OCSPCertStatus::Status::GOOD;
+ out->status = OCSPRevocationStatus::GOOD;
ParsedTbsCertificate tbs_cert;
if (!ParseTbsCertificate(cert_tbs_certificate_tlv, {}, &tbs_cert))
@@ -517,15 +517,15 @@ bool GetOCSPCertStatus(const OCSPResponseData& response_data,
found = true;
// In the case that we receive multiple responses, we keep only the
// strictest status (REVOKED > UNKNOWN > GOOD).
- if (out->status == OCSPCertStatus::Status::GOOD ||
- new_status.status == OCSPCertStatus::Status::REVOKED) {
+ if (out->status == OCSPRevocationStatus::GOOD ||
+ new_status.status == OCSPRevocationStatus::REVOKED) {
*out = new_status;
}
}
}
if (!found)
- out->status = OCSPCertStatus::Status::UNKNOWN;
+ out->status = OCSPRevocationStatus::UNKNOWN;
return found;
}
« no previous file with comments | « net/cert/internal/parse_ocsp.h ('k') | net/cert/internal/parse_ocsp_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698