Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: net/socket/ssl_client_socket_impl.cc

Issue 2100303002: Add OCSPVerifyResult for tracking stapled OCSP responses cross-platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ocsp-date-check
Patch Set: Add tests for REVOKED status Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_impl.cc
diff --git a/net/socket/ssl_client_socket_impl.cc b/net/socket/ssl_client_socket_impl.cc
index 01acc54ffcfe0c1d2f14381263c74147f1adf978..87851a16fd216568f21280d0d811878ba843b7ed 100644
--- a/net/socket/ssl_client_socket_impl.cc
+++ b/net/socket/ssl_client_socket_impl.cc
@@ -781,7 +781,6 @@ bool SSLClientSocketImpl::GetSSLInfo(SSLInfo* ssl_info) {
ssl_info->Reset();
if (server_cert_chain_->empty())
return false;
-
svaldez 2016/06/29 14:41:22 Typically keep the space after conditionals?
dadrian 2016/06/30 21:52:43 Done.
ssl_info->cert = server_cert_verify_result_.verified_cert;
ssl_info->unverified_cert = server_cert_;
ssl_info->cert_status = server_cert_verify_result_.cert_status;
@@ -795,6 +794,7 @@ bool SSLClientSocketImpl::GetSSLInfo(SSLInfo* ssl_info) {
ssl_info->token_binding_negotiated = tb_was_negotiated_;
ssl_info->token_binding_key_param = tb_negotiated_param_;
ssl_info->pinning_failure_log = pinning_failure_log_;
+ ssl_info->ocsp = server_cert_verify_result_.ocsp;
AddCTInfoToSSLInfo(ssl_info);
@@ -1301,7 +1301,6 @@ int SSLClientSocketImpl::DoVerifyCert(int result) {
}
start_cert_verification_time_ = base::TimeTicks::Now();
-
svaldez 2016/06/29 14:41:22 stray format?
dadrian 2016/06/30 21:52:43 Done.
return cert_verifier_->Verify(
CertVerifier::RequestParams(server_cert_, host_and_port_.host(),
ssl_config_.GetCertVerifyFlags(),

Powered by Google App Engine
This is Rietveld 408576698