Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2100253002: [telemetry] Replace enable_logging usage with logging_verbosity (Closed)

Created:
4 years, 5 months ago by petrcermak
Modified:
4 years, 5 months ago
Reviewers:
dtu
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Replace enable_logging usage with logging_verbosity This patch replaces the only usage of BrowserOptions.enable_logging with BrowserOptions.logging_verbosity. Context: https://codereview.chromium.org/2093923002/ BUG=623058 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/f24b374d53e9d99b782832dc3703faeff9774ca6 Cr-Commit-Position: refs/heads/master@{#402972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/test/gpu/gpu_tests/trace_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
petrcermak
Hi, can you please stamp this trivial change? Thanks, Petr
4 years, 5 months ago (2016-06-27 19:42:49 UTC) #3
dtu
lgtm
4 years, 5 months ago (2016-06-29 16:06:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100253002/1
4 years, 5 months ago (2016-06-29 20:23:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 22:43:50 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 22:44:15 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 22:47:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f24b374d53e9d99b782832dc3703faeff9774ca6
Cr-Commit-Position: refs/heads/master@{#402972}

Powered by Google App Engine
This is Rietveld 408576698