Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: third_party/WebKit/LayoutTests/fast/scrolling/keyboard-scroll-page-scale.html

Issue 2100243002: Remove non-standardize key code names from event_sender. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix inspector tests that were missed by sed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/scrolling/keyboard-scroll-page-scale.html
diff --git a/third_party/WebKit/LayoutTests/fast/scrolling/keyboard-scroll-page-scale.html b/third_party/WebKit/LayoutTests/fast/scrolling/keyboard-scroll-page-scale.html
index 252b5882b0ec612bc64fe8c08a19199f29801c38..2b12835401c296da3dbc5aac7e125d2efcbee700 100644
--- a/third_party/WebKit/LayoutTests/fast/scrolling/keyboard-scroll-page-scale.html
+++ b/third_party/WebKit/LayoutTests/fast/scrolling/keyboard-scroll-page-scale.html
@@ -14,19 +14,19 @@
function testArrowKeys()
{
// Test up and down.
- window.eventSender.keyDown('downArrow');
+ window.eventSender.keyDown('ArrowDown');
shouldBeGreaterThan('internals.visualViewportScrollY()', '0');
numScrolls = Math.ceil((pageHeight - internals.visualViewportHeight()) / internals.visualViewportScrollY());
for(var i = 0; i < numScrolls - 1; ++i) {
- window.eventSender.keyDown('downArrow');
+ window.eventSender.keyDown('ArrowDown');
}
shouldBe('internals.visualViewportScrollY()', 'pageHeight - internals.visualViewportHeight()');
for(var i = 0; i < numScrolls; ++i) {
- window.eventSender.keyDown('upArrow');
+ window.eventSender.keyDown('ArrowUp');
}
shouldBe('internals.visualViewportScrollY()', '0');
@@ -34,17 +34,17 @@
// Now test left and right.
reset();
- window.eventSender.keyDown('rightArrow');
+ window.eventSender.keyDown('ArrowRight');
numScrolls = Math.ceil((pageWidth - internals.visualViewportWidth()) / internals.visualViewportScrollX());
for(var i = 0; i < numScrolls - 1; ++i) {
- window.eventSender.keyDown('rightArrow');
+ window.eventSender.keyDown('ArrowRight');
}
shouldBe('internals.visualViewportScrollX()', 'pageWidth - internals.visualViewportWidth()');
for(var i = 0; i < numScrolls; ++i) {
- window.eventSender.keyDown('leftArrow');
+ window.eventSender.keyDown('ArrowLeft');
}
shouldBe('internals.visualViewportScrollX()', '0');
@@ -52,29 +52,29 @@
function testHomeEnd()
{
- window.eventSender.keyDown('end');
+ window.eventSender.keyDown('End');
shouldBe('window.scrollY', 'pageHeight - window.innerHeight');
shouldBe('internals.visualViewportScrollY()', 'pageHeight - internals.visualViewportHeight()');
- window.eventSender.keyDown('home');
+ window.eventSender.keyDown('Home');
shouldBe('window.scrollY', '0');
shouldBe('internals.visualViewportScrollY()', '0');
}
function testPageUpDown()
{
- window.eventSender.keyDown('pageDown');
+ window.eventSender.keyDown('PageDown');
shouldBeGreaterThan('internals.visualViewportScrollY()', '0');
numScrolls = Math.ceil((pageHeight - internals.visualViewportHeight()) / internals.visualViewportScrollY());
for(var i = 0; i < numScrolls - 1; ++i) {
- window.eventSender.keyDown('pageDown');
+ window.eventSender.keyDown('PageDown');
}
shouldBe('internals.visualViewportScrollY()', 'pageHeight - internals.visualViewportHeight()');
for(var i = 0; i < numScrolls; ++i) {
- window.eventSender.keyDown('pageUp');
+ window.eventSender.keyDown('PageUp');
}
shouldBe('internals.visualViewportScrollY()', '0');

Powered by Google App Engine
This is Rietveld 408576698