third_party/WebKit/LayoutTests/fast/forms/select/menulist-popup-open-hide-using-keyboard.html - Issue 2100243002: Remove non-standardize key code names from event_sender.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/forms/select/menulist-popup-open-hide-using-keyboard.html

Issue 2100243002: Remove non-standardize key code names from event_sender. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix inspector tests that were missed by sed Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/select/menulist-onchange-fired-with-key-up-down.html ('k') | third_party/WebKit/LayoutTests/fast/forms/select/menulist-type-ahead-find-original-item.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/forms/select/menulist-popup-open-hide-using-keyboard.html

diff --git a/third_party/WebKit/LayoutTests/fast/forms/select/menulist-popup-open-hide-using-keyboard.html b/third_party/WebKit/LayoutTests/fast/forms/select/menulist-popup-open-hide-using-keyboard.html

index c5656703427b1304ea443e63f70217cc9789af7d..4ac6b1980b83b83a31a94df5180268663e2e7f95 100644

--- a/third_party/WebKit/LayoutTests/fast/forms/select/menulist-popup-open-hide-using-keyboard.html

+++ b/third_party/WebKit/LayoutTests/fast/forms/select/menulist-popup-open-hide-using-keyboard.html

@@ -20,9 +20,9 @@ function test()

debug('Test opening and closing of popup using alt and down arrow key');

popup.focus();

- eventSender.keyDown('downArrow', ['altKey']);

+ eventSender.keyDown('ArrowDown', ['altKey']);

shouldBeTrue('internals.isSelectPopupVisible(popup)');

- eventSender.keyDown('downArrow', ['altKey']);

+ eventSender.keyDown('ArrowDown', ['altKey']);

// We need this delay because in ListPicker._handleKeyDown we hide the

// popup with a delay to avoid reopening the popup.

setTimeout(test2, 0);

@@ -32,9 +32,9 @@ function test2() {

debug('Test opening and closing of popup using alt and up arrow key');

popup.focus();

- eventSender.keyDown('upArrow', ['altKey']);

+ eventSender.keyDown('ArrowUp', ['altKey']);

shouldBeTrue('internals.isSelectPopupVisible(popup)');

- eventSender.keyDown('upArrow', ['altKey']);

+ eventSender.keyDown('ArrowUp', ['altKey']);

// We need this delay because in ListPicker._handleKeyDown we hide the

// popup with a delay to avoid reopening the popup.

setTimeout(test3, 0);

@@ -67,7 +67,7 @@ function test3() {

debug('Test opening of popup using up key');

popup.focus();

- eventSender.keyDown('upArrow');

+ eventSender.keyDown('ArrowUp');

shouldBeTrue('internals.isSelectPopupVisible(popup)');

popup.blur();