Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: third_party/WebKit/LayoutTests/fast/forms/range/range-keyoperation.html

Issue 2100243002: Remove non-standardize key code names from event_sender. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix inspector tests that were missed by sed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/forms/range/range-keyoperation.html
diff --git a/third_party/WebKit/LayoutTests/fast/forms/range/range-keyoperation.html b/third_party/WebKit/LayoutTests/fast/forms/range/range-keyoperation.html
index 7f9180254eda906aef4525fd984ab30bb1afc1d1..630043e6aff2824b67d75074d302e23b4692e10a 100644
--- a/third_party/WebKit/LayoutTests/fast/forms/range/range-keyoperation.html
+++ b/third_party/WebKit/LayoutTests/fast/forms/range/range-keyoperation.html
@@ -28,67 +28,67 @@ input.focus();
debug('Tests for a horizontal range');
debug('Press the up arrow key:');
var lastChangeEventCounter = changeEventCounter;
-sendKey(input, 'upArrow');
+sendKey(input, 'ArrowUp');
shouldBe('input.value', '"51"');
shouldBe('changeEventCounter', 'lastChangeEventCounter + 1');
debug('Press the down arrow key:');
-sendKey(input, 'downArrow');
+sendKey(input, 'ArrowDown');
shouldBe('input.value', '"50"');
debug('Press the left arrow key:');
-sendKey(input, 'leftArrow');
+sendKey(input, 'ArrowLeft');
shouldBe('input.value', '"49"');
debug('Press the right arrow key:');
-sendKey(input, 'rightArrow');
+sendKey(input, 'ArrowRight');
shouldBe('input.value', '"50"');
debug('Press the PageUp key:');
-sendKey(input, 'pageUp');
+sendKey(input, 'PageUp');
shouldBe('input.value', '"60"');
debug('Press the PageDown key:');
-sendKey(input, 'pageDown');
+sendKey(input, 'PageDown');
shouldBe('input.value', '"50"');
debug('Press the Home key:');
-sendKey(input, 'home');
+sendKey(input, 'Home');
shouldBe('input.value', '"0"');
debug('Press the End key:');
-sendKey(input, 'end');
+sendKey(input, 'End');
shouldBe('input.value', '"100"');
debug('Edge cases');
input.valueAsNumber = 0;
lastChangeEventCounter = changeEventCounter;
-sendKey(input, 'leftArrow');
+sendKey(input, 'ArrowLeft');
shouldBe('input.value', '"0"');
shouldBe('changeEventCounter', 'lastChangeEventCounter');
-sendKey(input, 'rightArrow');
+sendKey(input, 'ArrowRight');
shouldBe('input.value', '"1"');
input.valueAsNumber = 100;
-sendKey(input, 'rightArrow');
+sendKey(input, 'ArrowRight');
shouldBe('input.value', '"100"');
-sendKey(input, 'leftArrow');
+sendKey(input, 'ArrowLeft');
shouldBe('input.value', '"99"');
input.valueAsNumber = 0;
lastChangeEventCounter = changeEventCounter;
-sendKey(input, 'pageDown');
+sendKey(input, 'PageDown');
shouldBe('input.value', '"0"');
shouldBe('changeEventCounter', 'lastChangeEventCounter');
-sendKey(input, 'home');
+sendKey(input, 'Home');
shouldBe('input.value', '"0"');
shouldBe('changeEventCounter', 'lastChangeEventCounter');
input.valueAsNumber = 100;
lastChangeEventCounter = changeEventCounter;
-sendKey(input, 'pageUp');
+sendKey(input, 'PageUp');
shouldBe('input.value', '"100"');
shouldBe('changeEventCounter', 'lastChangeEventCounter');
-sendKey(input, 'end');
+sendKey(input, 'End');
shouldBe('input.value', '"100"');
shouldBe('changeEventCounter', 'lastChangeEventCounter');
@@ -97,9 +97,9 @@ input.value = '50';
input.offsetLeft;
debug('');
debug('RTL');
-sendKey(input, 'leftArrow');
+sendKey(input, 'ArrowLeft');
shouldBeEqualToString('input.value', '51');
-sendKey(input, 'rightArrow');
+sendKey(input, 'ArrowRight');
shouldBeEqualToString('input.value', '50');
input.dir = 'ltr';
@@ -110,35 +110,35 @@ input.offsetLeft; // force layout
input.valueAsNumber = 50;
debug('Tests for a vertical range');
debug('Press the up arrow key:');
-sendKey(input, 'upArrow');
+sendKey(input, 'ArrowUp');
shouldBe('input.value', '"51"');
debug('Press the down arrow key:');
-sendKey(input, 'downArrow');
+sendKey(input, 'ArrowDown');
shouldBe('input.value', '"50"');
debug('Press the left arrow key:');
-sendKey(input, 'leftArrow');
+sendKey(input, 'ArrowLeft');
shouldBe('input.value', '"51"');
debug('Press the right arrow key:');
-sendKey(input, 'rightArrow');
+sendKey(input, 'ArrowRight');
shouldBe('input.value', '"50"');
debug('Press the PageUp key:');
-sendKey(input, 'pageUp');
+sendKey(input, 'PageUp');
shouldBe('input.value', '"60"');
debug('Press the PageDown key:');
-sendKey(input, 'pageDown');
+sendKey(input, 'PageDown');
shouldBe('input.value', '"50"');
debug('Press the Home key:');
-sendKey(input, 'home');
+sendKey(input, 'Home');
shouldBe('input.value', '"100"');
debug('Press the End key:');
-sendKey(input, 'end');
+sendKey(input, 'End');
shouldBe('input.value', '"0"');
debug('');
@@ -150,79 +150,79 @@ input.valueAsNumber = 100;
debug('Press the up arrow key:');
lastChangeEventCounter = changeEventCounter;
-sendKey(input, 'upArrow');
+sendKey(input, 'ArrowUp');
shouldBe('input.value', '"102"');
shouldBe('changeEventCounter', 'lastChangeEventCounter + 1');
debug('Press the down arrow key:');
lastChangeEventCounter = changeEventCounter;
-sendKey(input, 'downArrow');
+sendKey(input, 'ArrowDown');
shouldBe('input.value', '"100"');
shouldBe('changeEventCounter', 'lastChangeEventCounter + 1');
debug('Press the pageup key:');
lastChangeEventCounter = changeEventCounter;
-sendKey(input, 'pageUp');
+sendKey(input, 'PageUp');
shouldBe('input.value', '"120"');
shouldBe('changeEventCounter', 'lastChangeEventCounter + 1');
debug('Press the pagedown key:');
lastChangeEventCounter = changeEventCounter;
-sendKey(input, 'pageDown');
+sendKey(input, 'PageDown');
shouldBe('input.value', '"100"');
shouldBe('changeEventCounter', 'lastChangeEventCounter + 1');
debug('Press the home key:');
lastChangeEventCounter = changeEventCounter;
-sendKey(input, 'home');
+sendKey(input, 'Home');
shouldBe('input.value', '"200"');
shouldBe('changeEventCounter', 'lastChangeEventCounter + 1');
debug('Press the end key:');
lastChangeEventCounter = changeEventCounter;
-sendKey(input, 'end');
+sendKey(input, 'End');
shouldBe('input.value', '"0"');
shouldBe('changeEventCounter', 'lastChangeEventCounter + 1');
debug('Edge cases');
input.valueAsNumber = 199;
-sendKey(input, 'upArrow');
+sendKey(input, 'ArrowUp');
shouldBe('input.value', '"200"');
lastChangeEventCounter = changeEventCounter;
-sendKey(input, 'upArrow');
+sendKey(input, 'ArrowUp');
shouldBe('input.value', '"200"');
shouldBe('changeEventCounter', 'lastChangeEventCounter');
-sendKey(input, 'downArrow');
+sendKey(input, 'ArrowDown');
shouldBe('input.value', '"198"');
input.valueAsNumber = 199;
-sendKey(input, 'pageUp');
+sendKey(input, 'PageUp');
shouldBe('input.value', '"200"');
lastChangeEventCounter = changeEventCounter;
-sendKey(input, 'pageUp');
+sendKey(input, 'PageUp');
shouldBe('input.value', '"200"');
shouldBe('changeEventCounter', 'lastChangeEventCounter');
-sendKey(input, 'pageDown');
+sendKey(input, 'PageDown');
shouldBe('input.value', '"180"');
input.valueAsNumber = 1;
-sendKey(input, 'downArrow');
+sendKey(input, 'ArrowDown');
shouldBe('input.value', '"0"');
lastChangeEventCounter = changeEventCounter;
-sendKey(input, 'downArrow');
+sendKey(input, 'ArrowDown');
shouldBe('input.value', '"0"');
shouldBe('changeEventCounter', 'lastChangeEventCounter');
-sendKey(input, 'upArrow');
+sendKey(input, 'ArrowUp');
shouldBe('input.value', '"2"');
input.valueAsNumber = 1;
-sendKey(input, 'pageDown');
+sendKey(input, 'PageDown');
shouldBe('input.value', '"0"');
lastChangeEventCounter = changeEventCounter;
-sendKey(input, 'pageDown');
+sendKey(input, 'PageDown');
shouldBe('input.value', '"0"');
shouldBe('changeEventCounter', 'lastChangeEventCounter');
-sendKey(input, 'pageUp');
+sendKey(input, 'PageUp');
shouldBe('input.value', '"20"');
debug('');
@@ -232,19 +232,19 @@ input.max = '10';
input.step = '3';
input.valueAsNumber = 6;
-sendKey(input, 'pageUp');
+sendKey(input, 'PageUp');
shouldBe('input.value', '"9"');
-sendKey(input, 'pageDown');
+sendKey(input, 'PageDown');
shouldBe('input.value', '"6"');
-sendKey(input, 'end');
+sendKey(input, 'End');
shouldBe('input.value', '"0"');
-sendKey(input, 'home');
+sendKey(input, 'Home');
shouldBe('input.value', '"9"');
-sendKey(input, 'end');
+sendKey(input, 'End');
shouldBe('input.value', '"0"');
@@ -256,20 +256,20 @@ input.step = '1';
input.value = '1';
input.disabled = true;
-sendKey(input, 'upArrow');
+sendKey(input, 'ArrowUp');
shouldBe('input.value', '"1"');
-sendKey(input, 'home');
+sendKey(input, 'Home');
shouldBe('input.value', '"1"');
-sendKey(input, 'pageUp');
+sendKey(input, 'PageUp');
shouldBe('input.value', '"1"');
input.removeAttribute('disabled');
input.readOnly = true;
-sendKey(input, 'upArrow');
+sendKey(input, 'ArrowUp');
shouldBe('input.value', '"1"');
-sendKey(input, 'home');
+sendKey(input, 'Home');
shouldBe('input.value', '"1"');
-sendKey(input, 'pageUp');
+sendKey(input, 'PageUp');
shouldBe('input.value', '"1"');
input.readOnly = false;

Powered by Google App Engine
This is Rietveld 408576698