third_party/WebKit/LayoutTests/fast/events/keyboard-scroll-by-page.html - Issue 2100243002: Remove non-standardize key code names from event_sender.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/keyboard-scroll-by-page.html

Issue 2100243002: Remove non-standardize key code names from event_sender. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix inspector tests that were missed by sed Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/key-events-in-input-text.html ('k') | third_party/WebKit/LayoutTests/fast/events/keyboardevent-code.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/keyboard-scroll-by-page.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/keyboard-scroll-by-page.html b/third_party/WebKit/LayoutTests/fast/events/keyboard-scroll-by-page.html

index 4f5c36d1a89fc6f369a49600ac0e11d2bca37265..58bc29201e2f9f3320c920fa848d3eaf2719e0d1 100644

--- a/third_party/WebKit/LayoutTests/fast/events/keyboard-scroll-by-page.html

+++ b/third_party/WebKit/LayoutTests/fast/events/keyboard-scroll-by-page.html

@@ -33,9 +33,9 @@

function keyboardScrollPageDown()

{

if (navigator.platform.indexOf('Mac') == 0) {

- eventSender.keyDown('downArrow', ["altKey"]);

+ eventSender.keyDown('ArrowDown', ["altKey"]);

} else {

- eventSender.keyDown('pageDown');

+ eventSender.keyDown('PageDown');

}

// see kMinFractionToStepWhenPaging = 0.875f in ScrollableArea.cpp

@@ -45,9 +45,9 @@ function keyboardScrollPageDown()

function keyboardScrollPageUp()

{

if (navigator.platform.indexOf('Mac') == 0) {

- eventSender.keyDown('upArrow', ["altKey"]);

+ eventSender.keyDown('ArrowUp', ["altKey"]);

} else {

- eventSender.keyDown('pageUp');

+ eventSender.keyDown('PageUp');

}

// PageDown + PageUp goes back to 0