Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-canceling.html

Issue 2100243002: Remove non-standardize key code names from event_sender. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix inspector tests that were missed by sed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-canceling.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-canceling.html b/third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-canceling.html
index 5c0d3984055391becf1a82007432317bde577c9f..cdf0168b9f4d18f8199d1805419060aac160e8d4 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-canceling.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-canceling.html
@@ -63,36 +63,36 @@ function test() {
return;
debug('Top dialog event listener should prevent closing.');
- eventSender.keyDown("escape");
+ eventSender.keyDown("Escape");
shouldBeTrue('topDialog.open');
shouldBeTrue('bottomDialog.open');
debug('Top dialog should close.');
- eventSender.keyDown("escape");
+ eventSender.keyDown("Escape");
shouldBeFalse('topDialog.open');
shouldBeTrue('bottomDialog.open');
debug('Input should swallow Escape mechanism.');
swallowInput.focus();
- eventSender.keyDown("escape");
- eventSender.keyDown("escape");
- eventSender.keyDown("escape");
+ eventSender.keyDown("Escape");
+ eventSender.keyDown("Escape");
+ eventSender.keyDown("Escape");
shouldBeFalse('topDialog.open');
shouldBeTrue('bottomDialog.open');
normalInput.focus();
debug('Bottom dialog event listener should prevent closing.');
- eventSender.keyDown("escape");
+ eventSender.keyDown("Escape");
shouldBeFalse('topDialog.open');
shouldBeTrue('bottomDialog.open');
debug('Bottom dialog should close.');
- eventSender.keyDown("escape");
+ eventSender.keyDown("Escape");
shouldBeFalse('topDialog.open');
shouldBeFalse('bottomDialog.open');
debug('Pressing Escape now should do nothing.');
- eventSender.keyDown("escape");
+ eventSender.keyDown("Escape");
shouldBeFalse('topDialog.open');
shouldBeFalse('bottomDialog.open');

Powered by Google App Engine
This is Rietveld 408576698