third_party/WebKit/LayoutTests/fast/forms/select/listbox-onchange.html - Issue 2100243002: Remove non-standardize key code names from event_sender.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/forms/select/listbox-onchange.html

Issue 2100243002: Remove non-standardize key code names from event_sender. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix inspector tests that were missed by sed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/select/click-size-zero-no-crash.html ('k') | third_party/WebKit/LayoutTests/fast/forms/select/listbox-oninput-fired.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script>	3 <script>

4 function setup()	4 function setup()

5 {	5 {

6 var results = document.createElement('div');	6 var results = document.createElement('div');

7 results.id = "res";	7 results.id = "res";

8 results.appendChild(document.createTextNode("Results:"));	8 results.appendChild(document.createTextNode("Results:"));

9 document.body.appendChild(results);	9 document.body.appendChild(results);

10 }	10 }

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
44 mouseDownOnSelect("sl1", 2, false, false);	44 mouseDownOnSelect("sl1", 2, false, false);

45 mouseUpOnSelect("sl1", 2, false, false);	45 mouseUpOnSelect("sl1", 2, false, false);

46 checkSelection("2");	46 checkSelection("2");

47	47

48 log("5) Make sure onChange fires when clicking on a new item");	48 log("5) Make sure onChange fires when clicking on a new item");

49 mouseDownOnSelect("sl1", 0, false, false);	49 mouseDownOnSelect("sl1", 0, false, false);

50 mouseUpOnSelect("sl1", 0, false, false);	50 mouseUpOnSelect("sl1", 0, false, false);

51 checkSelection("0");	51 checkSelection("0");

52	52

53 log("6) Make sure onChange fires when changing the selection wit h the keyboard");	53 log("6) Make sure onChange fires when changing the selection wit h the keyboard");

54 keyDownOnSelect("sl1", "downArrow", true, false);	54 keyDownOnSelect("sl1", "ArrowDown", true, false);

55 checkSelection("0,1");	55 checkSelection("0,1");

56	56

57 log("7) Make sure onChange doesn't fire when setting the select element's value from JS");	57 log("7) Make sure onChange doesn't fire when setting the select element's value from JS");

58 document.getElementById("sl1").value = "2";	58 document.getElementById("sl1").value = "2";

59 checkSelection("2");	59 checkSelection("2");

60	60

61 log("8) Make sure onChange doesn't fire when clicking on the alr eady selected option");	61 log("8) Make sure onChange doesn't fire when clicking on the alr eady selected option");

62 mouseDownOnSelect("sl1", 2, false, false);	62 mouseDownOnSelect("sl1", 2, false, false);

63 mouseUpOnSelect("sl1", 2, false, false);	63 mouseUpOnSelect("sl1", 2, false, false);

64 checkSelection("2");	64 checkSelection("2");

(...skipping 120 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
185 </head>	185 </head>

186 <body onload="test()">	186 <body onload="test()">

187 <select id="sl1" size=5 multiple onchange="log('onChange fired')">	187 <select id="sl1" size=5 multiple onchange="log('onChange fired')">

188 <option selected value="0">item 0</option>	188 <option selected value="0">item 0</option>

189 <option value="1">item 1	189 <option value="1">item 1

190 <option value="2">item 2	190 <option value="2">item 2

191 <option value="3">item 3	191 <option value="3">item 3

192 </select>	192 </select>

193 </body>	193 </body>

194 </html>	194 </html>

OLD	NEW