Issue 210023006: Revert 258831 "Revert 258727 "Implement ServiceWorker::postMessage()""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 210023006: Revert 258831 "Revert 258727 "Implement ServiceWorker::postMessage()"" (Closed)

Created:
6 years, 9 months ago by jsbell

Modified:
6 years, 9 months ago

Reviewers:
benwells

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, creis+watch_chromium.org, tzik, nasko+codewatch_chromium.org, jam, nhiroki, joi+watch-content_chromium.org, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert 258831 "Revert 258727 "Implement ServiceWorker::postMessage()"" The change was reverted due to a dependent Blink roll reversion. Blink's back, so is this change. TBR=benwells@chromium.org BUG=350103 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258957

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+204 lines, -33 lines)			Patch
M	content/browser/renderer_host/render_process_host_impl.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	content/browser/service_worker/service_worker_dispatcher_host.h	View	3 chunks	+18 lines, -1 line	0 comments	Download
M	content/browser/service_worker/service_worker_dispatcher_host.cc	View	4 chunks	+58 lines, -6 lines	0 comments	Download
M	content/browser/service_worker/service_worker_dispatcher_host_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/service_worker/service_worker_storage.h	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	content/browser/service_worker/service_worker_storage.cc	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	content/child/service_worker/service_worker_dispatcher.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/child/service_worker/web_service_worker_impl.h	View	1 chunk	+11 lines, -2 lines	0 comments	Download
M	content/child/service_worker/web_service_worker_impl.cc	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	content/child/webmessageportchannel_impl.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/child/webmessageportchannel_impl.cc	View	2 chunks	+20 lines, -14 lines	0 comments	Download
M	content/common/service_worker/service_worker_messages.h	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	content/renderer/service_worker/embedded_worker_context_client.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/service_worker/service_worker_script_context.h	View	3 chunks	+9 lines, -1 line	0 comments	Download
M	content/renderer/service_worker/service_worker_script_context.cc	View	3 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

jsbell

6 years, 9 months ago (2014-03-24 16:57:57 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r258957 (presubmit successful).

Expand Messages | Collapse Messages