Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2100223003: Check PremulType during GrGradientEffect::onIsEqual (Closed)

Created:
4 years, 5 months ago by csmartdalton
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Check PremulType during GrGradientEffect::onIsEqual BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2100223003 Committed: https://skia.googlesource.com/skia/+/523a239e531d88564b1f58b0c11674efe4f6f21c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
csmartdalton
4 years, 5 months ago (2016-06-27 20:39:06 UTC) #3
bsalomon
lgtm
4 years, 5 months ago (2016-06-27 20:40:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100223003/1
4 years, 5 months ago (2016-06-27 20:41:16 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 21:02:19 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/523a239e531d88564b1f58b0c11674efe4f6f21c

Powered by Google App Engine
This is Rietveld 408576698