Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2100223002:
Add a power test for blinking cursor. (Closed)
|
Created:
4 years, 5 months ago by erikchen Modified:
4 years, 5 months ago Reviewers:
nednguyen CC:
chromium-reviews, telemetry-reviews_chromium.org, charliea (OOO until 10-5), rnephew (Reviews Here) Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a power test for blinking cursor.
Also fix the browser args, which should have been "--disable-gpu", not
"--no-gpu".
BUG=616811
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
Committed: https://crrev.com/4eb467453200da5ced2cf5fcc7d0a3e234b28dae
Cr-Commit-Position: refs/heads/master@{#402487}
Patch Set 1 #
Messages
Total messages: 25 (14 generated)
Description was changed from ========== Add a power test for blinking cursor. Also fix the browser args for browser-args, which should have been "--disable-gpu", not "--no-gpu". BUG=616811 ========== to ========== Add a power test for blinking cursor. Also fix the browser args for browser-args, which should have been "--disable-gpu", not "--no-gpu". BUG=616811 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
erikchen@chromium.org changed reviewers: + nednguyen@google.com
nednguyen: Please review.
Description was changed from ========== Add a power test for blinking cursor. Also fix the browser args for browser-args, which should have been "--disable-gpu", not "--no-gpu". BUG=616811 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== Add a power test for blinking cursor. Also fix the browser args, which should have been "--disable-gpu", not "--no-gpu". BUG=616811 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Description was changed from ========== Add a power test for blinking cursor. Also fix the browser args, which should have been "--disable-gpu", not "--no-gpu". BUG=616811 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== Add a power test for blinking cursor. Also fix the browser args, which should have been "--disable-gpu", not "--no-gpu". BUG=616811 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/06/28 15:24:49, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... Removing the bot tryserver.chromium.perf:winx64_10_perf_cq because it keeps timing out.
Description was changed from ========== Add a power test for blinking cursor. Also fix the browser args, which should have been "--disable-gpu", not "--no-gpu". BUG=616811 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== Add a power test for blinking cursor. Also fix the browser args, which should have been "--disable-gpu", not "--no-gpu". BUG=616811 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
The CQ bit was unchecked by erikchen@chromium.org
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add a power test for blinking cursor. Also fix the browser args, which should have been "--disable-gpu", not "--no-gpu". BUG=616811 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== Add a power test for blinking cursor. Also fix the browser args, which should have been "--disable-gpu", not "--no-gpu". BUG=616811 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add a power test for blinking cursor. Also fix the browser args, which should have been "--disable-gpu", not "--no-gpu". BUG=616811 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== Add a power test for blinking cursor. Also fix the browser args, which should have been "--disable-gpu", not "--no-gpu". BUG=616811 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/4eb467453200da5ced2cf5fcc7d0a3e234b28dae Cr-Commit-Position: refs/heads/master@{#402487} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4eb467453200da5ced2cf5fcc7d0a3e234b28dae Cr-Commit-Position: refs/heads/master@{#402487} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
