Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2493)

Unified Diff: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html

Issue 2100203003: Pin keyboard matches red lines (go/cros-quick-unlock-ux). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fixed patch set 3 errors. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
diff --git a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
index 3e11127c88f77cb4ae9ebe5bcc67f79b487a93c4..59895a3bcf3f59a19afbcd818ab15f33a404c50f 100644
--- a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
+++ b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
@@ -18,39 +18,49 @@
display: flex;
}
- .row.horizontal-center {
- justify-content: center;
- }
-
.digit-button {
align-items: center;
background: none;
- border-radius: 50px;
+ border-radius: 20px;
box-sizing: border-box;
+ color: var(--paper-blue-grey-700);
display: flex;
flex-direction: column;
- font-size: 30px;
+ font-size: 32px;
height: 70px;
justify-content: center;
margin: 0;
min-height: 70px;
- min-width: 85px;
+ min-width: 70px;
padding: 15px 20px;
- width: 85px;
+ width: 70px;
}
.digit-button.clear-button {
display: block;
}
+ .digit-button.center-button {
+ margin: 0 30px;
+ }
+
+ .digit-button.submit-button {
+ left: 20px;
+ position: relative;
+ }
+
.digit-button .icon-container {
- background: var(--paper-grey-500);
+ background: var(--paper-grey-400);
border-radius: 100px;
height: 24px;
margin: auto;
width: 24px;
}
+ .digit-button .icon-container.ready-background {
+ background: var(--paper-blue-800);
+ }
+
.digit-button .icon-container .icon {
color: white;
display: block;
@@ -61,30 +71,39 @@
}
.digit-button .icon-subheading {
- color: var(--paper-grey-500);
+ color: var(--paper-grey-400);
font-size: 10px;
- padding: 10px;
+ left: 0;
+ position: absolute;
+ text-align: center;
text-transform: capitalize;
+ top: 44px;
+ width: 100%;
}
.digit-button inner-text {
+ color: var(--paper-blue-grey-700);
display: flex;
flex-direction: column;
height: 52px;
}
.first-row {
- height: 54px;
- min-height: 54px;
+ height: 64px;
+ min-height: 64px;
+ padding: 28px 15px 12px 15px;
}
#pin-input {
-webkit-text-security: disc;
border: 0;
- font-size: 20px;
- height: 54px;
+ font-size: 18px;
+ height: 64px;
+ left: 20px;
+ padding: 28px 3px 12px 3px;
+ position: relative;
text-align: center;
- width: 171px;
+ width: 180px;
}
#pin-input[type=number]::-webkit-inner-spin-button,
@@ -102,25 +121,24 @@
<div id="root">
<div id="container-constrained-width">
- <div class="row horizontal-center">
+ <div class="row">
<input id="pin-input" type="number" placeholder="Enter PIN"
value="{{value::input}}"
on-keydown="onInputKeyDown_"></input>
- <div class="digit-button first-row">
- <paper-button class="digit-button submit-button"
- on-tap="firePinSubmitEvent_">
- <div class="icon-container">
- <iron-icon class="icon" icon="icons:forward"><iron-icon>
- </div>
- </paper-button>
- </div>
+ <paper-button class="digit-button first-row submit-button"
+ on-tap="firePinSubmitEvent_">
+ <div class$="icon-container [[computeSubmitClass_(value)]]">
+ <iron-icon class="icon" icon="icons:forward"><iron-icon>
+ </div>
+ </paper-button>
</div>
<div class="row keyboard">
<paper-button class="digit-button" on-tap="onNumberTap_" value="1">
<inner-text>1</inner-text>
</paper-button>
- <paper-button class="digit-button" on-tap="onNumberTap_" value="2">
+ <paper-button class="digit-button center-button" on-tap="onNumberTap_"
+ value="2">
<inner-text>2</inner-text>
</paper-button>
<paper-button class="digit-button" on-tap="onNumberTap_" value="3">
@@ -131,7 +149,8 @@
<paper-button class="digit-button" on-tap="onNumberTap_" value="4">
<inner-text>4</inner-text>
</paper-button>
- <paper-button class="digit-button" on-tap="onNumberTap_" value="5">
+ <paper-button class="digit-button center-button" on-tap="onNumberTap_"
+ value="5">
<inner-text>5</inner-text>
</paper-button>
<paper-button class="digit-button" on-tap="onNumberTap_" value="6">
@@ -142,7 +161,8 @@
<paper-button class="digit-button" on-tap="onNumberTap_" value="7">
<inner-text>7</inner-text>
</paper-button>
- <paper-button class="digit-button" on-tap="onNumberTap_" value="8">
+ <paper-button class="digit-button center-button" on-tap="onNumberTap_"
+ value="8">
<inner-text>8</inner-text>
</paper-button>
<paper-button class="digit-button" on-tap="onNumberTap_" value="9">
@@ -151,7 +171,8 @@
</div>
<div class="row keyboard">
<div class="digit-button"></div>
- <paper-button class="digit-button" on-tap="onNumberTap_" value="0">
+ <paper-button class="digit-button center-button" on-tap="onNumberTap_"
+ value="0">
<inner-text>0</inner-text>
</paper-button>
<paper-button class="digit-button clear-button" on-tap="onPinClear_">

Powered by Google App Engine
This is Rietveld 408576698