Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js

Issue 2100203003: Pin keyboard matches red lines (go/cros-quick-unlock-ux). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Submit color now handled by bind. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html ('k') | ui/login/account_picker/user_pod_row.css » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'pin-keyboard' is a keyboard that can be used to enter PINs or more generally 7 * 'pin-keyboard' is a keyboard that can be used to enter PINs or more generally
8 * numeric values. 8 * numeric values.
9 * 9 *
10 * Properties: 10 * Properties:
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 event.preventDefault(); 77 event.preventDefault();
78 return; 78 return;
79 } 79 }
80 80
81 // Enter pressed. 81 // Enter pressed.
82 if (event.keyCode == 13) { 82 if (event.keyCode == 13) {
83 this.firePinSubmitEvent_(); 83 this.firePinSubmitEvent_();
84 event.preventDefault(); 84 event.preventDefault();
85 return; 85 return;
86 } 86 }
87 },
88
89 /**
90 * Changes the color of the submit button if PIN is ready.
91 * @param {string} value
92 */
93 computeSubmitClass_: function(value) {
94 var pinLength = value.length;
95 return pinLength > 0 ? 'ready-background' : '';
jdufault 2016/06/30 18:15:48 Inline value.length
sammiequon 2016/06/30 22:17:14 Done.
87 } 96 }
88 }); 97 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html ('k') | ui/login/account_picker/user_pod_row.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698