Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 210013003: Manual memset to work around bogus compiler warning bug. (Closed)

Created:
6 years, 9 months ago by mtklein_C
Modified:
6 years, 9 months ago
Reviewers:
bsalomon, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Manual memset to work around bogus compiler warning bug. BUG=skia:2215 Committed: http://code.google.com/p/skia/source/detail?r=13908

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tests/WritePixelsTest.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
6 years, 9 months ago (2014-03-24 14:52:12 UTC) #1
bsalomon
On 2014/03/24 14:52:12, mtklein wrote: size_t i? Seems OK but it'd be nice to have ...
6 years, 9 months ago (2014-03-24 15:01:17 UTC) #2
mtklein
On 2014/03/24 15:01:17, bsalomon wrote: > On 2014/03/24 14:52:12, mtklein wrote: > > size_t i? ...
6 years, 9 months ago (2014-03-24 15:04:20 UTC) #3
bsalomon
lgtm
6 years, 9 months ago (2014-03-24 15:29:09 UTC) #4
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-03-24 15:31:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/210013003/20001
6 years, 9 months ago (2014-03-24 15:31:57 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 15:52:35 UTC) #7
Message was sent while issue was closed.
Change committed as 13908

Powered by Google App Engine
This is Rietveld 408576698