Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 2100103002: Fix bug in BytesBuilder. Add tests. (Closed)

Created:
4 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 5 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
M sdk/lib/io/bytes_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/standalone/io/bytes_builder_test.dart View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
4 years, 5 months ago (2016-06-27 10:48:06 UTC) #2
floitsch
LGTM. Thanks.
4 years, 5 months ago (2016-06-27 22:37:51 UTC) #3
Lasse Reichstein Nielsen
4 years, 5 months ago (2016-06-28 12:34:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ddf35f2d56fb335c72388b05bfdba9391116593b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698