Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: tools/testing/dart/test_options.dart

Issue 21001003: test.py: First step towards support of caching dart2js compilations across runtimes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebased Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index 37a0411caadf357d9720ebbb72507c00b5398ac4..f66c4854a11d4b2bbedddf26b83316637a58eadf 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -39,18 +39,6 @@ class _TestOptionSpecification {
* Parser of test options.
*/
class TestOptionsParser {
- String specialCommandHelp =
-"""
-Special command support. Wraps the command line in
-a special command. The special command should contain
-an '@' character which will be replaced by the normal
-command executable.
-
-For example if the normal command line that will be executed
-is 'dart file.dart' and you specify special command
-'python -u valgrind.py @ suffix' the final command will be
-'python -u valgrind.py dart suffix file.dart'""";
-
/**
* Creates a test options parser initialized with the known options.
*/
@@ -225,19 +213,6 @@ is 'dart file.dart' and you specify special command
false,
'bool'),
new _TestOptionSpecification(
- 'valgrind',
- 'Run tests through valgrind',
- ['--valgrind'],
- [],
- false,
- 'bool'),
- new _TestOptionSpecification(
- 'special-command',
- specialCommandHelp,
- ['--special-command'],
- [],
- ''),
- new _TestOptionSpecification(
'time',
'Print timing information after running tests',
['--time'],
@@ -582,16 +557,6 @@ Note: currently only implemented for dart2js.''',
if (configuration['mode'] == 'all') {
configuration['mode'] = 'debug,release';
}
- if (configuration['valgrind']) {
- // TODO(ager): Get rid of this when there is only one checkout and
- // we don't have to special case for the runtime checkout.
- File valgrindFile = new File('runtime/tools/valgrind.py');
- if (!valgrindFile.existsSync()) {
- valgrindFile = new File('../runtime/tools/valgrind.py');
- }
- String valgrind = valgrindFile.fullPathSync();
- configuration['special-command'] = 'python -u $valgrind @';
- }
// Use verbose progress indication for verbose output unless buildbot
// progress indication is requested.

Powered by Google App Engine
This is Rietveld 408576698