Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: tools/test.dart

Issue 21001003: test.py: First step towards support of caching dart2js compilations across runtimes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebased Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/test.dart
diff --git a/tools/test.dart b/tools/test.dart
index cd43215718f65f5eecd6407709afd1615debdd61..192800eb6b654f06e2486f29e86bcdc0b0446bb6 100755
--- a/tools/test.dart
+++ b/tools/test.dart
@@ -102,18 +102,6 @@ void testConfigurations(List<Map> configurations) {
exit(1);
}
- var testCaseRecorder;
- if (recordingPath != null) {
- testCaseRecorder = new TestCaseRecorder(new Path(recordingPath));
- }
-
- var testCaseOutputArchive;
- if (recordingOutputPath != null) {
- testCaseOutputArchive = new TestCaseOutputArchive();
- testCaseOutputArchive.loadFromPath(new Path(recordingOutputPath));
- }
-
-
if (!firstConf['append_logs']) {
var file = new File(TestUtils.flakyFileName());
if (file.existsSync()) {
@@ -242,8 +230,10 @@ void testConfigurations(List<Map> configurations) {
eventListener.add(new ExitCodeSetter());
void startProcessQueue() {
- // Start process queue.
- new ProcessQueue(maxProcesses,
+ // [firstConf] is needed here, since the ProcessQueue needs to know the
+ // settings of 'noBatch' and 'local_ip'
+ new ProcessQueue(firstConf,
+ maxProcesses,
maxBrowserProcesses,
startTime,
testSuites,
@@ -251,8 +241,8 @@ void testConfigurations(List<Map> configurations) {
allTestsFinished,
verbose,
listTests,
- testCaseRecorder,
- testCaseOutputArchive);
+ recordingPath,
+ recordingOutputPath);
}
// Start all the HTTP servers required before starting the process queue.

Powered by Google App Engine
This is Rietveld 408576698