Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/test.dart

Issue 21001003: test.py: First step towards support of caching dart2js compilations across runtimes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/test.dart
diff --git a/tools/test.dart b/tools/test.dart
index 787a1db16b141bb8c8670e2fbb6312cbe5990eba..e78059235de88dbd19cb7a1a41ec1f8884a717ee 100755
--- a/tools/test.dart
+++ b/tools/test.dart
@@ -103,18 +103,6 @@ void testConfigurations(List<Map> configurations) {
exit(1);
}
- var testCaseRecorder;
- if (recordingPath != null) {
- testCaseRecorder = new TestCaseRecorder(new Path(recordingPath));
- }
-
- var testCaseOutputArchive;
- if (recordingOutputPath != null) {
- testCaseOutputArchive = new TestCaseOutputArchive();
- testCaseOutputArchive.loadFromPath(new Path(recordingOutputPath));
- }
-
-
if (!firstConf['append_logs']) {
var file = new File(TestUtils.flakyFileName());
if (file.existsSync()) {
@@ -251,7 +239,8 @@ void testConfigurations(List<Map> configurations) {
void startProcessQueue() {
// Start process queue.
- new ProcessQueue(maxProcesses,
+ new ProcessQueue(firstConf,
ricow1 2013/08/01 18:23:52 it seems a little odd to pass in the first conf, b
kustermann 2013/08/05 07:29:17 This is actually not odd. Strictly speaking, our c
+ maxProcesses,
maxBrowserProcesses,
startTime,
testSuites,
@@ -259,8 +248,8 @@ void testConfigurations(List<Map> configurations) {
allTestsFinished,
verbose,
listTests,
- testCaseRecorder,
- testCaseOutputArchive);
+ recordingPath,
+ recordingOutputPath);
}
// Start all the HTTP servers required before starting the process queue.

Powered by Google App Engine
This is Rietveld 408576698