test.py: First step towards support of caching dart2js compilations across runtimes

tools/test.dart

 #!/usr/bin/env dart
 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This file is the entrypoint of the dart test suite.  This suite is used
  * to test:
  *
  *     1. the dart vm
@@ skipping 85 matching lines @@
   // We set a special flag in the safari browser if we need to clear out
   // the cache before running.
   Safari.deleteCache = firstConf['clear_safari_cache'];
 
   if (recordingPath != null && recordingOutputPath != null) {
     print("Fatal: Can't have the '--record_to_file' and '--replay_from_file'"
           "at the same time. Exiting ...");
     exit(1);
   }
 
-  var testCaseRecorder;
-  if (recordingPath != null) {
-    testCaseRecorder = new TestCaseRecorder(new Path(recordingPath));
-  }
-
-  var testCaseOutputArchive;
-  if (recordingOutputPath != null) {
-      testCaseOutputArchive = new TestCaseOutputArchive();
-      testCaseOutputArchive.loadFromPath(new Path(recordingOutputPath));
-  }
-
-
   if (!firstConf['append_logs'])  {
     var file = new File(TestUtils.flakyFileName());
     if (file.existsSync()) {
       file.deleteSync();
     }
   }
 
   DebugLogger.init(firstConf['write_debug_log'] ?
       TestUtils.debugLogfile() : null, append: firstConf['append_logs']);
 
@@ skipping 116 matching lines @@
     if (printTiming) {
       eventListener.add(new TimingPrinter(startTime));
     }
     eventListener.add(new SkippedCompilationsPrinter());
     eventListener.add(new LeftOverTempDirPrinter());
   }
   eventListener.add(new ExitCodeSetter());
 
   void startProcessQueue() {
     // Start process queue.
-    new ProcessQueue(maxProcesses,
+    new ProcessQueue(firstConf,

[ricow1, 2013/08/01 18:23:52]

it seems a little odd to pass in the first conf, but I understand the incentive
to do so. Could you add a small comment stating why we do that?

[kustermann, 2013/08/05 07:29:17]

This is actually not odd. Strictly speaking, our configuration maps  are split
into two groups
- global settings
- settings specific to a given "configuration"

I added a comment.

+                     maxProcesses,
                      maxBrowserProcesses,
                      startTime,
                      testSuites,
                      eventListener,
                      allTestsFinished,
                      verbose,
                      listTests,
-                     testCaseRecorder,
-                     testCaseOutputArchive);
+                     recordingPath,
+                     recordingOutputPath);
   }
 
   // Start all the HTTP servers required before starting the process queue.
   if (serverFutures.isEmpty) {
     startProcessQueue();
   } else {
     Future.wait(serverFutures).then((_) => startProcessQueue());
   }
 }
 
@@ skipping 38 matching lines @@
 void main() {
   deleteTemporaryDartDirectories().then((_) {
     var optionsParser = new TestOptionsParser();
     var configurations = optionsParser.parse(new Options().arguments);
     if (configurations != null && configurations.length > 0) {
       testConfigurations(configurations);
     }
   });
 }